[00:55:28] Reedy: Was it you that said mw:Download_from_git should not point at master by default? https://www.mediawiki.org/w/index.php?title=Download_from_Git&diff=2726411&oldid=2707188&diffmode=source :-) [00:55:57] Ja [00:56:01] I'd filed https://phabricator.wikimedia.org/T188455 to come back to it [00:56:56] Kk. [00:57:08] We could almost do with making that use a lua template or something for latest version [00:57:13] rather than manually updating that... [00:58:18] https://www.mediawiki.org/wiki/Download_from_Git#Using_Git_to_download_MediaWiki_extensions should be fixed dsimilarly [02:58:11] tgr: my understanding is that a bunch of CLDR data is in core, but then there's some extra data like currency that the cldr extension adds as parser functions for fundraising? And there's some should be core functionality like language names that's still in the extension [03:00:21] legoktm: at a glance I can only see plural handling in core [03:01:01] maybe that's it :p [12:58:07] legoktm: It's nice to see my changes allowing constraints in composer.json (I know that was only the first part of the puzzle) actually being used more widely now :P [14:02:43] James_F: I hadn't really planned it either way. I don't know of any blockers to doing so, besides that we haven't actually been running it anywhere outside of me running unit tests locally with that setting. [14:03:16] legoktm: Extension updates are for the actor table, not the comment table. Unless people have introduced new code in extensions that needs fixing, comment table for deployed extensions has been done for a while now. [16:12:09] anomie: oops, my bad. re: luasandbox, did you test it on a 32-bit system? otherwise I can do that before merging [16:15:08] legoktm: I confirmed my analysis, but I forgot to actually load that patch and run it. [16:15:59] Reedy: :D it's pretty convenient now [16:25:33] legoktm: I'm slightly surprised we managed this long without it [16:31:46] I guess we didn't have dependency chains like this before [16:32:02] and most of the base libraries like utfnormal rarely require updates [17:26:56] 17:22:25 | Filename | Old % | New % | [17:26:56] 17:22:25 +--------------------------------------------+--------+--------+ [17:26:56] 17:22:25 | includes/password/PasswordPolicyChecks.php | 97.92 | 88.68 | [17:26:59] :( [17:29:40] -1 [17:30:58] I added a test for the new code though [17:31:31] https://gerrit.wikimedia.org/r/#/c/414603/ [18:23:26] copy pasta fail it seems [18:43:26] Reedy: what was the issue? [18:43:47] The function the covers said it was calling wasn't the one it was calling [18:44:46] oh :) [18:58:21] anomie: https://gerrit.wikimedia.org/r/415360 [19:00:46] * anomie looks [19:03:12] thanks :) [21:04:20] MaxSem: wanna +2 https://gerrit.wikimedia.org/r/#/c/414930/ ? [21:04:35] MaxSem: also is there a reason that repo is owned by "search" and not "mediawiki"? [21:06:15] legoktm: I should get the bloom-filter guy to add the stuff to stop composer adding the dot files [21:06:41] because it's not a MW extension? :P also, I'm not its maintainer so I don't know anything [21:07:26] Reedy: that would be nice, I reviewed the tests/ and they didn't contain any directly executable code [21:07:45] MaxSem: who should I ask? [21:07:57] Erik? [21:08:14] legoktm: Just ".* export-ignore" in .gitattributes? [21:09:15] and tests [21:09:34] I always use cdb as my reference point: https://gerrit.wikimedia.org/r/plugins/gitiles/cdb/+/master/.gitattributes [21:11:04] composer.json too/ [21:14:37] yeah, it's not required [21:16:35] PR sent [23:05:14] legoktm: I live to make you happy: https://gerrit.wikimedia.org/r/415477 [23:57:53] James_F: <3