[00:09:55] CindyCicaleseWMF: sorry, had to go quell some fires and then got distracted and forgot about it [00:10:27] I did a hard refresh in Chrome and can't reproduce the issue anymore [00:10:41] it's not related to zoom, that works fine [00:19:47] 00:18:30 [PhpParser\Error] [00:19:47] 00:18:30 Syntax error, unexpected T_IS_IDENTICAL, expecting ']' on line 340 [00:19:48] Helpful [00:22:20] anomie: Any idea how to get the pg updater to add a PK? [00:22:59] changeField? [00:42:05] Can I wrangle anyone into merging some nice MW core deprecations/removals? ;-) https://gerrit.wikimedia.org/r/#/c/415183/ https://gerrit.wikimedia.org/r/#/c/415186/ https://gerrit.wikimedia.org/r/#/c/415188/ [01:13:17] legoktm: BTW, codesearch seems to have died. :-( [01:31:19] James_F: I think for GWToolset we kinda just need to merge it, and find people to test it on beta [01:31:46] Reedy: Yes. "Just". [01:31:56] I'll go and self CR+2 it [01:32:01] that's one problem solved ;) [01:32:14] Reedy: Can we get it actually tested on Staging before the cut on Tuesday? [01:32:45] Dunno... [01:32:56] I honestly wouldn't know where to get a test xml file for it etc [01:33:27] Me neither. [01:34:24] https://www.mediawiki.org/wiki/Template:GWToolset_abstract [01:34:28] * Reedy wonders why this is a template [01:34:53] https://www.mediawiki.org/w/index.php?title=Template%3AGWToolset_abstract&type=revision&diff=2728065&oldid=2593526 [01:34:57] That's more accurate now [01:35:30] I haven [01:35:49] I haven't see dan-nl around for a long time :/ [01:36:21] indeed [01:36:29] I wonder how actively used the extension actually is atm [01:36:30] https://commons.wikimedia.org/w/index.php?title=Special%3ALog&type=gwtoolset&user=&page=&year=&month=-1&tagfilter=&hide_thanks_log=1&hide_patrol_log=1&hide_tag_log=1 [01:36:47] you don't have to worry about people not noticing if it gets broken, at least [01:37:08] Well, last time it blew up the fatal log during the train. [01:37:24] I wonder when it last worked [01:37:26] If it doesn't fatal, we'll get shouts very quickly, yes. [01:37:51] anyway, regulars of the mass import talk page on commons can probably be sniped into testing it on beta [01:38:12] that log history looks like a single stuck busted input file [01:38:28] https://commons.wikimedia.org/w/index.php?title=Special:Log&offset=&limit=5000&type=gwtoolset&user=&page=&tagfilter=&hide_thanks_log=1&hide_patrol_log=1&hide_tag_log=1 [01:38:39] James_F: died? [01:38:41] There's a lot of 404ing [01:38:58] examples? [01:39:16] legoktm: https://codesearch.wmflabs.org/search/ -> "Unable to contact hound. If says "starting up", please wait a few minutes for the initial indexing to complete." [01:39:32] GWToolset is a neat idea, but should have been built as an OAuth tool on Toolforge [01:39:35] legoktm: Which says that search is down. [01:39:48] bd808: We didn't have OAuth at the time, did we? [01:39:51] bd808: (But agreed.) [01:40:04] we *almost* did :) [01:40:27] I guess no one read the "If this error continues, please report it in Phabricator" part :p [01:40:36] legoktm: I didn't want to waste time. ;-) [01:40:45] * legoktm logs in [01:41:02] > The last Puppet run was at Thu Mar 1 10:55:00 UTC 2018 (885 minutes ago). [01:41:04] this is gonna be bad [01:47:43] (we're debugging in -cloud now) [03:52:06] no_justification: boo, edit conflict [03:53:07] That silly rfc? [03:53:34] yeah [03:54:07] Also shows no matter how much you try to announce something, someone will always be surprised. [03:59:55] These RfCs are mostly xkcd 1172 every time [04:03:53] no_justification: I left a more detailed proposal at the bottom on how we could theoretically do truncation without shooting ourselves in the foot [04:04:01] (also there's some discussion in -en-admins) [14:01:43] Reedy: There doesn't seem to currently be a function to add a PK for PG. The SQL would be "ALTER TABLE foo ADD PRIMARY KEY (columns)". [14:02:13] Yeah, I'd done the sql patch https://gerrit.wikimedia.org/r/#/c/376068/14/maintenance/postgres/archives/patch-user_newtalk-fix-pk.sql [14:02:19] Just didn't know how to plumb it in [14:03:46] Seemed addTable etc was doable for running a sql patch.. The rest it was patchwork functions for functionality [14:04:34] Probably addIndex, using the name PG assigns to the PK by default. Look at PostgresUpdater line 485 for example. [14:06:22] Duh. Thanks [14:06:37] I'm sure I searched for addIndex [14:06:39] Apparently I didn't [14:19:28] Done [16:24:12] anomie: Just noticed an issue in DatabaseUpdater::migrateComments [16:24:16] $ok is undefined on the last line [16:24:24] I'll make a patch [16:25:15] https://gerrit.wikimedia.org/r/415880 [16:26:01] * anomie +2s [16:32:19] re https://gerrit.wikimedia.org/r/#/c/376068/15/includes/installer/MssqlUpdater.php@121 -- I can probably add a thing to MssqlUpdater which lets you rename automatically generated indexes by passing the column names as an array to renameIndex() [16:32:28] which beats out updatelog by a long margin imo [16:37:54] anomie: wanna meet today? [17:11:57] bd808: Sorry, I forgot. [17:15:52] anomie: no worries. we can catch up next week :) [21:55:38] legoktm: https://en.wikipedia.org/w/index.php?title=Wikipedia%3AVillage_pump_%28proposals%29&type=revision&diff=828491976&oldid=828491148 :p [22:01:32] LOL [23:41:06] That legoktm is such a spammer [23:43:19] Reedy: what's sad is how many were wrong, the + symbol was way too easy to miss [23:43:30] I suspect that most -only repositories, the author probably meant -or-later [23:44:17] https://github.com/wikimedia/mediawiki/commit/a501544a10a4193e50369463dff720af0d998cd4 [23:44:23] Think it's worth backporting that to REL1_27? [23:44:32] (and possibly other branches?) [23:44:44] yeah [23:44:44] Unblocks the DonationInterface patch [23:44:50] Incoming then [23:45:10] My goal for 1.31 is to have the legacy identifiers fail validation [23:47:06] Well, that's fun. REL1_27 doesn't have omposer/spdx-licenses [23:47:28] we used to have a manual list of licenses in the schema [23:47:50] it was grossly incomplete, which is why we moved to the library [23:47:57] heh [23:48:00] but we could just add the new licenses to that hardcoded list? [23:51:17] https://github.com/wikimedia/mediawiki/blob/c1edd28ba660411ecc4207533d522926c82913fc/includes/registration/ExtensionJsonValidator.php#L95 [23:51:21] It uses the same class? [23:51:56] Oh, hang on [23:52:00] github browsing... [23:56:01] https://gerrit.wikimedia.org/r/#/c/416171/ wow [23:59:09] {{done}}