[00:22:22] re: meetbot, I filed a bug about the 2 bots ages ago, but not sure who to poke next. IIRC we tried just kicking one, and it rejoins, so it does need to be solved at a lower level. https://phabricator.wikimedia.org/T186040 [00:24:31] quiddity: I'll fix it if y'all can't figure out how to stop grid jobs.... [01:26:42] is there any good solution for using TestingAccessWrapper with methods that accept by-ref args? [04:13:54] legoktm: I think there's a phpunit config that will reject @cover for a class or method that isn't used by the test, right? I can't seem to find it... [04:14:10] would've helped with https://gerrit.wikimedia.org/r/#/c/417188/ :) [04:14:40] I'm not aware of one [16:32:13] SMalyshev: You could do $wrapper->__call( 'method', [ &$arg ] ) [17:34:39] anomie: hmm... yeah I guess that would work [17:35:40] a bit clunky but i haven't found any way to do it without explicit array [17:49:31] James_F: Yeah, that'd be the best way [18:00:01] stupid json and trailing commas [18:01:12] addshore: the task you mentioned was T187586, right? [18:01:12] T187586: Installer fails in RevisionStore - https://phabricator.wikimedia.org/T187586 [18:12:48] legoktm: Do we have a way of handling extensions that want to add global functions for use in LocalSettings? [18:12:53] Well, two questions there.... [18:13:05] One, where do we add/define them in an extension.json? [18:13:42] And two, obviously that's not gonna work unless they stick it in a callback in wgextensionfunctions or similar [18:14:54] tgr: yup [19:00:07] CindyCicaleseWMF: https://www.mediawiki.org/wiki/Multi-Content_Revisions/Database_Schema [19:00:36] DanielK_WMDE: thanks [19:04:00] CindyCicaleseWMF: i also just tagged the gerrit changes you asked about. [19:04:37] DanielK_WMDE: :-D Excellent! Thanks! [19:20:39] James_F: "What a mess. Not tested. Almost certainly doesn't work, and some bits definitely won't." [19:20:42] You were right :P [19:21:01] Reedy: :-) [19:21:10] I think.. As of the latest patch, it should be all working [19:21:19] Just gotta work out about that global function [19:21:22] Really? I'm… surprised. [19:21:39] Yeah, that pained me most. [19:23:16] We might need to ask legoktm nicely... Cause we should have some sort of "files" like PSR does for composery stuff [19:23:27] But I don't see anyway that's gonna work without a callback [19:24:35] Just Say No? [19:24:58] Move it to Translate::omgwtfareyouDoing()? [19:25:09] lol [19:26:45] Reedy: no, running code in LocalSettings.php is what I want to avoid. Maybe Translate could have a $wgTranslateInitNamespaces[NS_FOO] = 'whatever'; and then they have a callback that runs the code they want? [19:28:07] Yeah. [19:29:59] 19:24:29 PHP Notice: Undefined index: value in /home/jenkins/workspace/mwext-testextension-php70-jessie-non-voting/src/includes/registration/ExtensionProcessor.php on line 487 [19:30:33] manifest_version 2 using old config method? [19:30:45] https://gerrit.wikimedia.org/r/#/c/391645/15/extension.json [19:30:52] Presumably for one of them [19:30:54] But not all [19:31:33] TranslateTranslationServices is wrong [19:32:10] others look right [19:33:12] 19:24:37 [config.TranslateTranslationServices.value] The property value is required [19:33:12] 19:24:37 ' matches expected false. [19:33:17] It was in there :P [19:34:18] Yeah, that needs some more indenting [19:36:21] Hmm [19:36:26] wtf did James_F do there? :P [19:36:51] Umm. [19:37:08] $wgTranslateTranslationServices['TTMServer'] = [ [19:37:08] 'database' => false, // Passed to wfGetDB [19:37:08] 'cutoff' => 0.75, [19:37:08] 'type' => 'ttmserver', [19:37:08] 'public' => false, [19:37:09] ]; [19:37:14] lol [19:37:31] Oh yeah, that one. [19:37:39] * Reedy fixes [19:37:50] Too much "clever" config in that repo. [19:39:03] Reedy: Also if you can replace the autoload classes with PSR that'd be nice. [19:39:08] Reedy: Maybe later. :-) [19:39:12] Haha [19:39:13] Yeah [19:39:25] That'd require moving a lot of files around [19:39:26] 300 lines to save. [19:39:34] Details, details. [19:46:18] James_F: The other problem is the translate back compat [19:46:28] When did we add PSR autoloading to mw core? [19:47:00] The desire to be backwards-compatible is a nice-to-have. It doesn't trump production deployment reality. [19:47:19] Well, sure [19:47:36] But when you have a maintainer that needs/wants that back compat for various reasons [19:53:29] Plus namespacing needed for PSR [20:06:56] * James_F shrugs. [20:41:15] Woo. PHP7 tests pass [20:48:03] It's amusing how much quicker php7 is at tests in comparison to hhvm [20:49:34] php 7.2 is even faster [20:49:53] It's hard to say that universally ;) [20:50:02] Under tested benchmarks, sure [21:06:27] James_F: https://gerrit.wikimedia.org/r/#/c/391645/25..26/extension.json [21:06:35] And that's the RL changes I hadn't already changed... [21:14:33] Reedy: Re-sync? [21:14:46] ? [21:16:29] James_F: Re-sync what? [21:21:28] Reedy: PSR-4 autoloading is in 1.31+ [21:21:41] Yeah, I thought it wouldn't work for Translate yet :P [21:21:42] Ta [21:22:31] Reedy: Sorry, was in meeting. Was the change based on re-syncing/basing with master as to what the current RL modules look like? [21:22:38] Original patch is from four months ago… [21:22:42] Yeah, pretty much [21:22:45] Wasn't blaming you :P [21:25:53] Oh, but you should. :-) [21:27:27] Hopefully we can get Niklas to merge the patch very soon [21:33:51] anomie: https://phabricator.wikimedia.org/T189251#4036620 [21:34:10] That looks like it's possibly caused by your actor table patch [21:36:22] * anomie looks [21:39:52] * anomie wishes the logs included URLs [21:42:51] * anomie finds one [21:50:16] Reedy: https://gerrit.wikimedia.org/r/417450