[04:03:49] <davidwbarratt>	 I'm on MediaWiki master and there is a FOUC
[04:03:57] <davidwbarratt>	 I'm assuming this is a known issue?
[05:30:08] <legoktm>	 davidwbarratt: more details?
[05:31:59] <davidwbarratt>	 legoktm hmm, nvm, it looks specific to Special:Block
[06:06:50] <legoktm>	 It's probably the Firefox autofocus issue I'd guess
[18:24:21] <Reedy>	 brion: https://phabricator.wikimedia.org/T189319
[18:53:19] <brion>	 Reedy: is that a spacing difference? Weird.
[18:54:41] <Reedy>	 Yeah, looks like a newline going awol
[18:59:53] <Reedy>	 Be interesting to see if that blocks ohter extensions...
[19:04:37] <brion>	 does it have tidy installed?
[19:04:41] <brion>	 or is it using the tidy replacement?
[19:04:55] <Reedy>	 It's CI/jenkins
[19:05:11] <brion>	 yes?
[19:05:33] <Reedy>	 We'd have to ask legoktm what he did for tidy in the php7 tests
[19:05:37] <brion>	 k
[19:05:48] <Reedy>	 Might be just a config/missing package type issue
[19:06:33] <brion>	 ugh i'm going to have to update all these test cases for the new frontend cause a couple html attribs are different. sighhhhh
[19:09:34] <legoktm>	 Reedy, brion: uh that should have been fixed...
[19:09:57] <Reedy>	 :(
[19:10:19] <Reedy>	 Something not deployed?
[19:10:27] <legoktm>	 also https://gerrit.wikimedia.org/r/#/c/417490/ passed php 7
[19:10:37] <legoktm>	 which patch failed?
[19:10:52] <Reedy>	 https://gerrit.wikimedia.org/r/#/c/417915/
[19:11:12] <Reedy>	 Gate failed, main was fine
[19:11:14] <legoktm>	 ohhh
[19:11:15] <legoktm>	 wmf branch
[19:11:43] <legoktm>	 let me disable php 7 on wmf/1.31.0-wmf.24 
[19:11:51] <legoktm>	 starting with .25 it'll pass
[19:12:01] <Reedy>	 heh
[19:12:15] <brion>	 which php version do we have on php 7?
[19:12:23] <legoktm>	 7.0 currently
[19:12:34] <brion>	 ok, i've got 7.2 locally and ..... there's a lot of warnings ;)
[19:12:46] <legoktm>	 count() and each() stuff?
[19:12:49] <Reedy>	 Yeah... 7.1 and 7.2 break/fix more shit
[19:12:58] <brion>	 yep
[19:13:15] <legoktm>	 each() is from an old version of PHPUnit, once we upgrade to PHPUnit 6 those will go away
[19:13:28] <legoktm>	 but that's next week :p
[19:13:41] <brion>	 :D
[19:15:04] <brion>	 XMPParser seems broken on 7.2
[19:16:59] <Reedy>	 Tests for it are broken on 7.1 too https://phabricator.wikimedia.org/T182365
[19:17:28] <legoktm>	 :(
[19:17:47] <brion>	 i'll look at that while i'm in there :D
[19:28:03] * Reedy waits for PHP 7.3 bugs to start coming in
[19:57:30] <brion>	 well i'll be darned it was a non-numeric string used in artihmetic and a count of a scalar where it should have been the containing array