[00:24:32] lol 62 files [00:37:50] legoktm: btw, do you have time for https://gerrit.wikimedia.org/r/#/c/416619/ this week? [00:43:34] I'll try, it's on my list [02:16:54] TimStarling: Hmm, my phone didn't remind me about the meeting. [02:17:51] it's getting pretty late now, right? [02:18:19] Yeah, but we can have a quick 1:1 if we want. [15:53:06] Is there a way in gitiles to easily make a link equivalent to ? Specifically, highlighting multiple lines and won't break if another commit changes the line numbers. I can't find useful docs in a quick search :( [15:56:30] anomie: Idk about multiple lines, but.... [15:56:36] https://gerrit.wikimedia.org/g/mediawiki/core/+/ad7db3c9b5751913b3823e82f2e9e43a2cc6ad3f/includes/MediaWiki.php#333 [15:56:45] Would be a stable URL across commits yeah [15:58:03] no_justification: Do you have to manually look up the current git hash and insert it into the URL, or is there somewhere simple you can click when starting from https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/ that will get you there? [15:58:38] clicked includes -> mediawiki.php [15:58:47] -> log [15:58:52] Then the sha1? [15:59:18] Or if you're looking at a /commit/, you should be able to click "tree" from there? [16:02:30] I note that gets me to the root of the tree for the last edit to that file. Clicking log then the sha1 gets me to the root of the tree for the latest revision in the whole repo. Either way, then I have to click includes -> MediaWiki.php again (or copy-paste it). I suppose that's workable. [16:03:13] ... s/Clicking log then the sha1/Clicking log then the sha1 before clicking includes -> MediaWiki.php/ [16:04:53] Oh, that's only from Or I suppose I could just copy-paste the hash from the "commit" line at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master. The trailing slash changes it. [16:05:39] ... Ugh, not doing well with writing/copy-pasting this morning. [16:05:55] * anomie notices it's now 5 minutes after noon here. Double ugh. [22:10:54] anyone know where these failures inhttps://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-jessie/20708/console come from? looks like an extension? [22:11:22] oh, never mind .. evidently, i cannot read file paths [23:44:58] [Wqhh7gpEE4AAAGOhsOUAAAAQ] /w/index.php?title=Special:%E6%97%A5%E5%BF%97/block&page=User%3A127.0.0.1&uselang=en MWException from line 1136 of /srv/mediawiki/php-master/languages/Language.php: Language::sprintfDate: The timestamp 100000101075959 should have 14 characters [23:45:00] lol, gj MW