[12:11:47] <AryehGregor>	 What's the preferred policy for minor corrections to comments etc.?  Should I make a whole commit just for that and get someone to give a summary +2?
[14:16:03] <anomie>	 AryehGregor: I don't think there's any real policy, just do it like you'd do any other patch. Bundling comment updates for a whole subsystem can be advantageous since it's less "clutter" for the git history.
[14:21:38] <AryehGregor>	 Okay.
[17:31:48] <AryehGregor>	 anomie: FYI, I work an Israeli workweek, which is Sunday-Thursday, so I won't be around tomorrow (or any Friday).
[17:32:04] <anomie>	 AryehGregor: Ok, thanks for the heads-up.
[17:32:05] <AryehGregor>	 (in case it changes anything in terms of your code review)
[17:32:34] <AryehGregor>	 Also, the clock here moves ahead one hour tonight, although that probably doesn't change anything much for you.
[18:08:56] <bd808>	 legoktm, Keegan: random, but should https://meta.wikimedia.org/wiki/Help:Unified_login be updated to make it more clear that all new accounts are SUL accounts and most of that page is historical?
[18:39:49] <AryehGregor>	 How am I supposed to push to Gerrit if my patch depends on a different patch from elsewhere?
[18:43:05] <Keegan>	 bd808: Probably.
[18:45:01] <paladox>	 AryehGregor hi, you could use Depends-On: <change-id>
[18:45:04] <paladox>	 in the commit msg
[18:45:28] <MaxSem>	 grrrrr
[18:45:34] <AryehGregor>	 paladox: Right, but in my local repo I have the patch it depends on applied.  How do I get gerrit to only send the tip patch for review, and not the patch beneath it (which is not yet on master)?
[18:45:56] <paladox>	 Hmm, not sure
[18:46:11] <MaxSem>	 all those random people who get sysop on testwiki, then mess with messages, then you try to reproduce something but can't because of that
[18:46:44] <bd808>	 AryehGregor: is the parent patch one that you downloaded from gerrit? If so gerrit is smart and will see that when you push
[18:47:41] <AryehGregor>	 bd808: I cherry-picked it, so it was smart and saw that it was a gerrit patch and rebased the other person's commit.  :)  https://gerrit.wikimedia.org/r/c/421344
[18:48:02] <bd808>	 yeah. gerrit is spooky like that, but you'll get used to it
[19:35:08] <no_justification>	 AaronSchulz: Notice: Undefined index: method in /srv/mediawiki/php-1.31.0-wmf.26/extensions/FlaggedRevs/backend/FlaggedRevs.hooks.php on line 1186
[19:46:36] <AaronSchulz>	 no_justification: how often?
[19:55:37] <no_justification>	 Just a few instances I think
[19:58:26] <no_justification>	 14 instances in last ~15m
[20:12:00] <AaronSchulz>	 no_justification: probably 74eacad8d646c6a2b17775dd8e37fd48108ab469
[23:15:22] <greg-g>	 no_justification: AaronSchulz Amir1 is noticing more of those during swat (flaggedrevs notices)
[23:15:42] <Amir1>	 https://phabricator.wikimedia.org/T190475
[23:15:57] <Amir1>	 Just made this hope it's not a duplicate :D
[23:36:36] <no_justification>	 greg-g, Amir1, AaronSchulz: Yeah, the number went up a tad after I initially reported, but didn't seem widespread enough to worry
[23:36:56] <Amir1>	 noted
[23:37:25] <AaronSchulz>	 no_justification: blame MaxSem ;)
[23:37:41] * no_justification blames all developers
[23:37:50] * MaxSem denies everything
[23:37:58] <AaronSchulz>	 the 'method' => 'undo' or whatever was removed
[23:38:06] <AaronSchulz>	 *from the array
[23:58:50] <Krinkle>	 legoktm: ping RE https://gerrit.wikimedia.org/r/#/c/260376/