[11:55:35] tgr|away: Thanks a lot, worked perfeclty. [11:55:37] perfectly. [18:05:20] paladox: Grr. Pressing up and down arrows on the main page in Gerrit's new UI doesn't scroll the page (so I can read more comments, for example). Instead it jumps up to the file list and scrolls a useless-to-me highlight in that. [18:05:54] anomie does it work on https://gerrit-new.wmflabs.org/r/ or https://gerrit-test.wmflabs.org/gerrit/ ? [18:06:00] they are running the newer versions [18:06:18] this will help to tell if it is still a problem or still in the current code [18:08:22] paladox: gerrit-new seems to work for this use case, gerrit-test seems to have the same problem. [18:08:30] ah ok [18:08:35] gerrit-test is running 2.15 [18:08:43] gerrit-new is running straight of the master branch [18:11:58] anomie is this on the change screen and not on the change list? [18:12:06] That will help to narrow down where to look :) [18:12:22] as the components are named with easy names :) [18:13:02] paladox: https://gerrit-test.wmflabs.org/gerrit/c/test/+/1269 and https://gerrit-new.wmflabs.org/r/c/test/+/6 for examples [18:13:11] thanks [18:21:23] anomie aha [18:21:29] i found the fix that fixed this [18:21:31] it's https://github.com/GerritCodeReview/gerrit/commit/7b550ef34b7509e571b764486ede33b0b1b83833#diff-c5c21ae7bc779e9fbbd7d5283c2397cc [18:21:46] took some time as i had to figure out if it was gr-change-view or gr-file-list* [18:22:06] i carn't backport it to 2.14 [18:22:15] as polygerrit is experimental in 2.14 [18:22:21] but from 2.15+ it is supported [18:22:54] https://gerrit-review.googlesource.com/c/gerrit/+/169050 [18:22:57] fixed in ^^ [18:35:53] anomie well that will need to be in 2.15.1 then [18:35:59] 2.15 was just released right now https://gerrit-review.googlesource.com/c/gerrit/+/169070 [18:58:40] About time! [18:58:53] Plus, I don't trust gerrit .0 releases, we'd wait for .1 anyway :p [19:01:22] yeh :) [19:01:31] expecially with notedb we should wait for .1 [21:03:36] > Maps can't find CR-R119 Chambers [49in LCD TV, Conference room AV system] [21:03:36] > Make sure your search is spelled correctly. Try adding a city, state, or zip code. [21:03:49] Thanks Google, that's very helpful. [21:21:34] can I get a review of this train blocker, please? https://gerrit.wikimedia.org/r/c/422547/ [21:22:04] patch by aaron, if that increases/decreases your willingness :) [21:33:14] anyone? I don't want to start pinging people [21:36:24] greg-g: threats sound lame, just start abusing people straight away :D [21:36:35] MaxSem: hey MaxSem wanna review :) [21:36:45] I was 10 second away from pinging you, ftr [21:37:36] (if it merges quickly we can still get the train moving before swat) [21:39:09] thanks MaxSem [21:54:32] James_F: "The 16-byte, randomly-generated sync marker for this file." :P [21:54:39] my plan's not gonna fly [21:55:04] MaxSem: Eurgh. [21:55:08] MaxSem: Clearly not. [21:55:40] MaxSem: But testing that it round-trips is a start. [21:55:53] well, it does round trip:P [22:13:23] MaxSem: So… success. Drop the compare-with-file and declare it done. :-) [22:14:06] so... yeah [22:14:49] the format has several blobs with undefined order. our code uses one order, the source file's generator used another one [22:15:40] the difference is friggin' 16 bytes random noise at the end and order of blobs before that [22:16:38] also, our friggin' codec removes whitespace from JSON schema... [22:17:02] no friggin' point in trying to test round tripping [22:17:08] bleh [22:22:12] legoktm: can we merge https://gerrit.wikimedia.org/r/#/c/422418/ ? [22:58:41] MaxSem: sure