[00:42:53] MaxSem: Now you need to release a new version of avro-php. [04:59:38] Today I learned about lcg_value() in PHP. [04:59:53] Seems quite similar in use to how we often use mt_rand(0,x)=0 etc for sampling. But maybe better? [05:00:34] Found in https://github.com/census-instrumentation/opencensus-php/blob/v0.3.0/src/Trace/Sampler/ProbabilitySampler.php [15:02:43] Why do we not ship with any skins in git? It would be helpful for testing to have at least one skin available by default. [15:03:38] AryehGregor vector was moved out many years ago [15:03:49] so that you have to clone the skin you want [15:04:02] Why, though? [15:21:11] I carn't remeber the reason as it was around 1.23 [16:39:29] the main reason was to ensure that "core" skins aren't reaching too far into core, and give non-core skins all the same functionality [16:39:30] https://www.mediawiki.org/wiki/Separating_skins_from_core_MediaWiki [16:40:33] legoktm heh he left [16:46:20] legoktm: You could make a decent argument for Vector as a submodule on master, though [16:47:14] Although I kinda wanted all bundled extensions & skins to be submodules tbh [16:47:28] Also! We should remove Monobook from bundling [16:48:00] why monobook? [16:48:46] Because MonoBook was the old default, I know of a few sites that implemented "skins" as custom CSS on top of it [16:49:06] Fair enough. Modern and CologneBlue tho? [16:49:08] cologneblue/modern otoh... [16:49:10] Yeah [16:50:26] https://gerrit.wikimedia.org/r/#/c/422963/ [16:51:57] * legoktm looks to see if wikiapiary has default usage stats [16:52:12] I wonder if we could get MwPingback to report skin usage [16:52:18] (I mean we could. Should we?) [16:52:47] MonoBook default usage: 1998, Modern: 251, CologneBlue: 11 [16:53:43] Definitely will need a mention in the release e-mails if we do drop these [16:56:59] I wrote a longer commit message for you :) [17:35:44] We should unbundle all but one skin, whatever it is. [18:29:56] legoktm: Do you have time to revisit https://gerrit.wikimedia.org/r/#/c/415834/ (PHPUnit 4+6)? PHP7 is now voting… [18:36:20] yeah, I guess I need to figure out what's going wrong there [18:41:45] James_F: now let's merge each other's patches? :P [18:42:34] MaxSem: Sure, but let's wait until after Metrics. [18:43:07] after metrics I eat!