[14:33:03] Do we actually use ct_log_id? I don't see any logic in LogEntry.php that adds the tags for the log entry, only for the RC entry. [15:07:29] I also don't see any UI to add tags for anything. [15:07:37] Do manually-added tags actually work at all? [15:07:40] Or only via the API? [15:08:39] . . . is it a holiday or something? [15:12:20] * AryehGregor discovers he wasn't finding the tag in the database because he was using text instead of dbkey, SIGH [15:12:32] Why do we have separate text and DBkey forms again? [15:12:40] Other than "because we always did"? [15:18:53] includes/api/ApiQueryLogEvents.php [15:45:56] I don't think its a holiday today [15:54:37] only a holiday in Greece AFAIK. :) [16:24:40] anomie: re https://phabricator.wikimedia.org/T172165#3699606 did we ever come up with a list of PHP 7.0 features that were incompatible with our HHVM in production? [16:24:56] I'd like to do the final codesniffer release for 1.31 around the end of this week [16:30:24] legoktm: Besides https://phabricator.wikimedia.org/T173786#3651007 that lists the ones controlled by hhvm.php7.all? Not that I know of. I suppose someone would have to look through all the rest of the PHP7 changes and see whether HHVM missed any. [18:29:02] legoktm: Want to merge https://gerrit.wikimedia.org/r/425093 then? :-) [20:06:18] legoktm: btw, still awaiting GlobalCssJs/Rl patch review https://phabricator.wikimedia.org/T188689#4067205 when you have a minute :) [20:38:00] Krinkle: right sorry, I've been prioritizing 1.31 stuff this week :/ [20:39:32] bd808: would you be interested in taking a look at https://phabricator.wikimedia.org/T191712 ? it appears monolog related :) [20:41:20] legoktm: see if you can nerd snipe ebernhardson with that one. He did the kafka stuff for monolog [20:42:35] legoktm: hi. Thanks a ton for the tidy 5.2 hint :] I completely overlooked the parser tests failling would be due to a different tidy version ^o^ [20:48:50] hashar: np :) [20:48:53] bd808: will try [22:34:41] legoktm: Can you write and send the wgValidateAllHtml removal announcement e-mail? [22:35:22] Yeah, I can do that tonight [22:36:17] legoktm: Thanks! [22:49:33] James_F: if you have time, I could use reviews on https://gerrit.wikimedia.org/r/#/q/status:open+topic:phan+-message:WIP (minus Scribunto) [22:50:02] legoktm: I was waiting for phab to be voting. Is it now? [22:50:15] no [22:50:39] Should it be? [22:50:46] yes :) [22:51:04] maybe you could +1 saying it's just waiting on CI, and then I can enable and +2 around the same time later tonight? [22:51:10] Sure. [22:53:31] legoktm: Do we care about mwext-php70-phan-seccheck-docker failing (on CategoryTree)? [22:53:57] not yet, that's a whole different set of problems [22:54:01] Right-o. [22:55:49] https://phabricator.wikimedia.org/T182599#4004941 is the current status [22:58:07] legoktm: Looks like the Thanks extension doesn't have any experimental jobs defined? [22:59:14] uhh [22:59:27] Or at least, `check experimental` doesn't do anything. [22:59:54] legoktm: And who's going to land https://gerrit.wikimedia.org/r/#/c/423577/ (PlatformSettings) for you before REL1_31? [23:00:27] huh, for some reason Thanks isn't running extension-unittests-generic [23:00:45] 🤷🏽‍♂️ [23:01:01] James_F: not sure, I put it on the list to ask for review in our MWPT weekly meeting, but I don't think it needs review from anyone specific at this point [23:01:16] But you really want it merged before the LTS gets cut. :-) [23:01:29] Yes [23:01:50] I'll merge it at the end of the week if no-one else has. [23:01:55] ok, thanks