[01:01:00] I seem to be logged in now, after reconnection [02:28:38] Might have to do with Freenode's NickServ outage earlier last week during which many session were left in a logged-in state that was recognised by services, but not by ChanServ. Seems to only be recoverable by reconnecting. [02:29:01] And presumably affecting other services as well [08:54:54] no_justification: how do I get the raw source in gitiles? [08:55:21] there is a format=TEXT option but it does not do anything comprehensible [08:55:44] (and format=JSON just dies) [10:49:34] tgr|away: hi that’s not supported yet, there’s a change pending for review [10:49:37] https://gerrit-review.googlesource.com/#/c/gitiles/+/78140/ [11:11:32] oh, that gerrit looks much nicer than our gerrit! [11:35:34] tgr: hey! how far did you get with the selenium stuff? [11:35:58] is there something I can do to help with the test wikis? [11:38:54] DanielK_WMDE_ that new ui will be in 2.16 / 3.0. (the polygerrit ui will have a updated look when we go to 2.15) [11:40:00] \o/ [11:40:32] DanielK_WMDE_: haven't tried yet, I can do it now [11:42:51] tgr: it's not super urgent. but it'S the thing that blocks PageUpdater being merged :) [11:43:39] I owe a spec for SlotRoleHandler and friends, so I plan to work on that today. But I can also look into setting up mcr-full or mcr-sdc, if you like. [11:44:17] I'm not very into that puppet stuff, though. i can use roles and stuff, but modifying them is a different matter [11:51:54] DanielK_WMDE_: I can do that, I do write puppet patches every once in a while [11:52:11] I don't think mcr-sdc is needed any time soon though [11:52:25] only when the rendering patches need to be tested [12:12:38] true [13:37:15] tgr: https://gerrit.wikimedia.org/r/plugins/gitiles/integration/utils/+/master/wikimediaci_utils/__init__.py#27 is how all of my scripts do it [13:38:10] oh, base6, I see [13:38:24] I was looking for something that's easy to copy&paste from [13:40:37] a user script maybe? [15:22:51] tgr, DanielK_WMDE_: the "container in a container" thing for MediaWiki on Cloud VPS is basically because it works better. The operations/puppet.git things are very production specific and difficult to apply for a random VM. There is a longer story about running 2 sets of puppet code on the same host and them fighting over files too. [15:40:38] bd808: yea, i can imagine it's easier in terms of setup. it just sounds very inefficient. [15:40:46] well, a container in a container may be fiine. [15:40:55] a vm in a vm... probably not? [15:41:08] the perf on the LXC container is ok [15:41:58] anomie: I changed https://gerrit.wikimedia.org/r/c/435822/ to "unknown user" earlier today. [15:42:27] it also turns out that modern CPUs have things to make hypervisor in hypervisor work better. its a thing people do in the real world [15:45:13] James_F: How much of a PITA would it be making newer oojsui point releases to remove at-ease? [15:45:32] ie cherry picking https://github.com/wikimedia/oojs-ui/commit/428c237555b0e795b30d333dd5e676994da942e1#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780 onto old branches used by REL1_27/29/30 and making new point releases? [15:46:03] Reedy: Umm. Quite painful, at a guess. [15:46:20] We'd need to also cherry-pick (or write from scratch) the patches to stop using it. [15:46:32] Well, not really [15:46:37] It's do-able but… [15:46:38] It's been unused since 0.15 [15:47:12] REL1_27 uses oojs ui 0.17.1 [15:47:18] Hmm. OK… [15:47:26] https://github.com/wikimedia/oojs-ui/commit/b28e997123b12b598eed9409afe6eff329f66e77 [15:47:50] However. It's all a lot of effort for the purposes of Translates back compat policy... [15:47:51] DanielK_WMDE_: the selenium tests pass [15:48:09] although there are only 10 of them which seems suspiciously little [15:48:22] So you want to make 0.17.1-no-at-ease, 0.21.1-no-at-ease, and 0.23.0-no-at-ease with that patch? [15:48:46] Something like that [15:48:53] Or just bump to newest point release [15:49:00] Like I say, it's a lot of effort for just one extension [15:49:07] Reedy: We could of course just make a dirty use of the library in MW, unless you're doing something that's actually parsing those composer.json files? [15:49:17] s/parsing/fetching from Packagist/ [15:49:47] Translate back-compat. is "last two MW releases", i.e. 1.30 and if we wait a week 1.31, right? [15:49:55] tgr: *sigh* [15:50:04] Not exactly sure [15:50:17] tgr: i did some manual testing yesterday, and all looked good. [15:50:39] do we want to test will all the fun extensions (and their selenium tests)? or is this good enough for you to merge the patch? [15:51:06] James_F: Yeah, you're right [15:51:07] "MLEB policy: master + 2 latest stable releases" [15:51:51] Reedy: Back-porting that hack just for REL1_30 (or for all three) is do-able if needed, I'm just suspicious. :-) [15:52:07] So we don't have to do REL1_27 now.. We don't need to do REL1_29 soon either [15:52:13] Yup. [15:52:38] DanielK_WMDE_: I'll play with the extensions a bit, and merge at the end of the day [15:53:17] excellent! [15:53:37] https://github.com/wikimedia/oojs-ui/compare/v0.23.0...v0.23.5 [15:53:37] :/ [15:53:38] there are a few follow-ups to perhaps could go in as well. [16:00:01] Why am I not being logged into other projects? :/ [16:04:44] Reedy: Why the ":/"? [16:05:18] Lots of changes [16:05:41] I was wondering if we can just make a temporary branch, cherry pick to that branch, make a new point release ontop of 0.23.5 and then rm the branch [16:06:31] Reedy: Oh. No. OOUI is one of the most actively developed repos we have. [16:06:38] Reedy: I can do it for you. [16:09:08] Reedy: https://gerrit.wikimedia.org/r/#/c/436052/ [16:33:05] // Blobs generated by MediaWiki < 1.5 on PHP 4 were serialized with the [16:33:14] Sounds like stuff we won't be able to remove in a hurry... [17:42:52] Reedy hi, wondering could you review https://gerrit.wikimedia.org/r/#/c/435689/ please? :) [22:22:43] TimStarling: you're listed as the author of https://test.wikipedia.org/wiki/Special:UnicodeConverter - do we still need it? [22:25:58] legoktm, others: I put the 1.31.0-rc.1 up on releases.wikimedia.org. I think the patchfile is shitty though, makerelease.py is being wonky in that dept. [22:26:04] Would love some other eyes before I send announcement [22:26:50] https://releases.wikimedia.org/mediawiki/1.31/ [22:28:47] Reedy: So… I've got https://gerrit.wikimedia.org/r/#/c/436176/ for REL1_30 for you, but (a) wow did that take a lot of effort, and (b) the /vendor patch is V-1'ing because of a PHP 5.6 dependency(!) that was pre-existing. [22:29:25] MaxSem: UnicodeConverter was a demo extension on how special page extensions work, I'm not sure it was ever needed for anything [22:29:32] James_F: p_0 [22:29:34] o_0 [22:29:45] How did that ever work? [22:29:53] It ran on HHVM? [22:29:56] no_justification: taking a look now [22:30:31] heh https://github.com/wikimedia/mediawiki-extensions-UnicodeConverter/commit/404dd0f26f98398fd3bddde11b75a74877accb30 [22:31:11] "new autoload" :D [22:38:21] no_justification: um, I think rc.0 is inside the rc.1 tarball [22:38:33] Well...that's not right at all. [22:38:51] Ugh. I bet I know why [22:38:56] like there's a rc.0 directory inside of rc.1 [22:38:59] ok :) [22:40:07] xD [22:40:20] I think I know where I messed up [22:42:07] There's a bunch of directory jumps that have to exist for composer update to work [22:42:12] * no_justification shrugs [22:42:36] oh [22:42:57] I never followed up on the usage of mw/vendor [22:43:20] Nope! [22:43:27] (in which case I could just drop said code) [22:43:53] my personal blamewheel points to finals, I blame finals [22:44:00] Ok, I think it's cloning properly now :) [22:44:06] yes, we should bundle mediawiki/vendor instead [22:44:10] should I submit a patch for that? [22:44:43] That'd be nice :) [22:44:55] Also: did we clean out the "junk" from the REL1_* branches? [22:45:02] So we don't re-break the "it's too big" bug? [22:45:27] let me do that first [22:46:03] side question, are we ok with the current set of bundled extensions? can we punt the remaining open ones to 1.32? [22:46:18] cc: CindyCicaleseWMF, tgr|away ^ [22:46:57] I'm fine with it [22:47:18] -rw-r--r-- 1 chad staff 270K May 29 15:45 mediawiki-1.31.0-rc.1.patch.gz [22:47:21] Muchhhhh more reasonable [22:50:52] * paladox wonders why macs put us in the staff group. [22:51:25] legoktm: Heh, this would explain a lot of my failures to generate patches https://gerrit.wikimedia.org/r/#/c/436184/ [22:51:26] :) [22:58:51] And bam, it all works again! [22:58:52] Yay! [22:59:24] Feature suggestion: move excludes to .gitattributes and just that with -X instead of a billion -x params [23:01:15] ugh, https://gerrit.wikimedia.org/r/#/c/436186/ fails tests [23:01:51] New tars + sigs uploaded [23:01:57] 22:54:56 Fatal error: Class undefined: Wikibase\DataModel\Entity\ItemId in /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikibase/lib/WikibaseLib.entitytypes.php on line 35 [23:02:00] Let's get it fixed for final release, rc.1 can still be ok [23:02:02] Yeah... I've seen that in a few branches [23:02:04] sounds good [23:02:08] Wikidata messing quite a few things up [23:09:22] legoktm: https://phabricator.wikimedia.org/T195929 [23:10:32] Reedy: er [23:10:39] that's because I just deleted all of their dependencies [23:10:43] Haha [23:11:03] It's a bit daft.... [23:11:32] I was thinking we'd just disable all the non-tarball extensions from the shared extension job if its on a REL1_ branch [23:11:59] that would at least need a announcement so users know they have to composer install now [23:12:13] Why would it? [23:12:53] Because users going from prevous mw would have had the deps already installed i think. [23:13:27] That doesn't make any sense [23:19:38] no_justification: I guess the tarball got cached in varnish since I got the old one? [23:21:44] Probably. Just append some useless query param