[16:37:52] <James_F>	 Reedy_: After all the work I put into making it, it'd be nice if you merged https://gerrit.wikimedia.org/r/#/c/436173/ https://gerrit.wikimedia.org/r/#/c/436176/ ;-)
[17:21:22] <tgr>	 Uncaught ExtensionDependencyError: Citoid requires VisualEditor to be installed.
[17:21:36] <tgr>	 how does that make sense?
[17:21:55] <tgr>	 I could see it going the other way...
[17:22:25] <DanielK_WMDE>	 tgr: well, if citoid hooks into visual editor, it depends on it...
[17:22:39] <DanielK_WMDE>	 Citoid extends VE, so it depends on it.
[17:23:09] <DanielK_WMDE>	 (dependencies for extensions work differently from dependencies for libraries)
[17:23:48] <tgr>	 a WMF supported extension without a documentation page, wow :/
[17:26:05] <Krenair>	 I don't think that extension does much beyond provide VisualEditor-Citoid integration, does it?
[17:26:11] <Krenair>	 maybe it'd poorly named
[17:26:15] <Krenair>	 it's*
[17:26:35] <no_justification>	 legoktm: Did the second batch of tars look ok?
[17:26:41] <no_justification>	 If so, I'll craft & send the announcement for rc.1
[17:28:00] <tgr>	 seems to be a collection of VE javascript modules
[17:28:28] <tgr>	 so yeah, the dependency makes sense, it just shouldn't be in the citoid vagrant role
[17:28:49] <Krenair>	 why not?
[17:29:04] <Krenair>	 can't the role also depend on VE?
[17:30:52] <tgr>	 why have a separate citoid and visualeditor role then?
[17:31:07] <tgr>	 they can't each depend on the other
[17:31:11] <Krenair>	 VE doesn't depend on Citoid being installed
[17:31:22] <Krenair>	 AFAIK
[17:31:56] <tgr>	 the VE role does require the citoid role though
[17:32:09] <no_justification>	 That sounds like a bad role then
[17:32:25] <Krenair>	 maybe it has started requiring that since I stopped paying close attention :)
[17:32:50] <tgr>	 but you are right, turning that around would be one way to fix it
[17:53:30] <legoktm>	 no_justification: yep, it looks good
[17:53:44] <no_justification>	 Awesome, I'll craft & send the e-mail
[17:54:21] <legoktm>	 no_justification: might be worth calling out that there is a schema change since rc.0
[17:55:51] <no_justification>	 Ah crap
[17:55:57] <no_justification>	 I forgot to bump the version # before tagging....
[17:56:09] <no_justification>	 My tarball test caught this :(
[17:56:29] <legoktm>	 yay test? :)
[17:56:55] <no_justification>	 I think we should wrap the tagging process in a script
[17:57:00] <no_justification>	 Rather than DIY
[17:57:11] <no_justification>	 Hmmm, so bump to rc.2 and re-tag?
[17:57:16] <no_justification>	 And skip rc.1?
[17:57:30] <no_justification>	 The tag's been up for a few days
[17:57:32] <no_justification>	 :\
[17:58:04] <no_justification>	 Then I pull in extra REL1_31 commits not in the original rc.1
[17:58:06] <no_justification>	 Ugh
[17:58:49] <no_justification>	 Eh, not much of a change, just a Timeless submodule  bump + some release notes
[17:59:16] <no_justification>	 Yeah, I'll bump the version #
[17:59:19] <legoktm>	 either seems fine
[17:59:20] <no_justification>	 Then tag as rc.2
[17:59:25] <no_justification>	 And mention in announcement
[17:59:31] <no_justification>	 That rc.1 was sorta skipped
[18:00:56] <no_justification>	 https://gerrit.wikimedia.org/r/#/c/436342/
[18:02:08] <no_justification>	 Should the diffs be against rc.0 or rc.1?
[18:02:15] <no_justification>	 Or both :)
[18:02:46] <no_justification>	 I'll do both, just to be good about it
[18:03:52] <no_justification>	 Sadly, our patch naming convention doesn't support multiple patches :P
[18:32:40] <no_justification>	 legoktm: Before I push the tag, is this correct to you?
[18:32:41] <no_justification>	 https://phabricator.wikimedia.org/P7188
[18:33:19] <legoktm>	 no_justification: yep, looks right
[18:33:30] <no_justification>	 Ok, pushing. Then I'll generate new tars.
[18:35:37] <no_justification>	 I figured rather than confuse it, and since the diff is so small, I'll just do rc.1 -> rc.2 patches
[18:35:45] <no_justification>	 I doubt many people upgrade via patch anyway, especially for rc's
[18:35:54] <no_justification>	 So I'll include notes in the announcement
[18:48:08] <no_justification>	 legoktm: Draft announcement: https://etherpad.wikimedia.org/p/rc.2-announce
[18:48:16] <no_justification>	 (and others, if you want)
[19:01:11] <James_F>	 no_justification: LGTM.
[19:07:37] <legoktm>	 no_justification: lgtm from my phone
[19:12:35] <hasharAway>	 legoktm: hello :) I might have found a fix for PropertySuggester failling to install due to a class not found :]
[19:12:59] <hasharAway>	 legoktm: the extension registry readFromQueue() does not initialize the Autoloader with the psr4 namespaces
[19:13:27] <hasharAway>	 I got you a patch for mediawiki/core and the magic bot added you as a reviewer
[19:41:43] <no_justification>	 James_F, legoktm: Sent
[19:42:54] <Krinkle>	 AaronSchulz: btw, could you see if there's something in https://gerrit.wikimedia.org/r/#/c/317167/ that is useful and/or feedback for it? I wanted to review this volunteer's patch but not really familiar with the Redis code. 
[19:54:39] <no_justification>	 Derp, uploading files before sending an e-mail would be smart
[19:54:55] <legoktm>	 hasharAway: will take a look
[20:11:26] <hasharAway>	 legoktm: you are my hero :]
[20:14:51] <legoktm>	 :))
[20:14:55] <legoktm>	 thanks for the patch
[20:15:06] <legoktm>	 James_F: are we ok to start merging PHP 7 stuff now?
[20:19:37] <hasharAway>	 legoktm: doesn't it need a backport to rel1_31 as well?
[20:19:47] <legoktm>	 hasharAway: it does, I'll do that once it merges
[20:20:01] <hasharAway>	 thanks!
[20:39:19] <James_F>	 legoktm: Maybe? How did the train roll out? Any issues?
[20:40:20] <legoktm>	 none on https://phabricator.wikimedia.org/T191052 yet
[20:43:48] <anomie>	 Looks like the wmf.6 train only went as far as testwiki so far, not even all of group 0.
[20:44:47] <legoktm>	 welp
[20:45:53] <legoktm>	 oh, scap just finished
[20:46:26] <James_F>	 Shall we wait a little before rushing in with PHP56-only changes?
[20:46:36] <James_F>	 Let alone the 70 ones. :-)
[20:48:33] <James_F>	 legoktm: On the other thing, the recheck on 436196 isn't going well…
[20:49:16] <James_F>	 legoktm: "20:45:32 30 05 2018 20:45:32.744:ERROR [launcher]: Cannot start Chrome" on all three quibble jobs.
[20:49:25] <legoktm>	 uhh looking
[20:54:33] <legoktm>	 there's no difference in the packages themselves...
[21:02:44] <legoktm>	 https://paste.fedoraproject.org/paste/6wowc4R4dmQHAonwNA3i7A
[21:03:07] <legoktm>	 I'll just revert it all
[21:41:45] <MatmaRex>	 hmm, why has this change not gotten merged? https://gerrit.wikimedia.org/r/#/c/435200/
[21:53:23] <James_F>	 MatmaRex: Jenkins hiccup maybe?
[22:15:43] <paladox>	 legoktm hi, wondering could you review https://gerrit.wikimedia.org/r/#/c/435689/ please?
[22:15:48] <paladox>	 Or James_F ^^ :)
[22:16:09] <paladox>	 Would like to deploy that change as some of our users doint like the noitce (outside of the eu)
[22:20:03] <paladox>	 Or MatmaRex ^^
[22:20:09] <legoktm>	 paladox: it's on my list, but I've just been dealing with other stuff lately
[22:20:15] <paladox>	 ok