[00:00:43] <legoktm>	 hmmm
[00:06:58] <legoktm>	 I can't think of why that would happen off the top of my head
[00:09:46] <Reedy>	 Computer suck?
[00:09:48] <Reedy>	 Want a bug filing?
[00:11:08] <legoktm>	 yes please
[00:11:14] <legoktm>	 I'll look at it in a bit
[00:12:17] <legoktm>	 seems to be something with phpunit not being installed properly?
[06:43:55] <Sonia>	 can anyone help me?
[12:59:46] <DanielK_WMDE>	 tgr: http://mcr-sdc.wmflabs.org/wiki/File:Mallewalkers-Schule-Wald-Berge.jpg
[12:59:55] <DanielK_WMDE>	 http://mcr-sdc.wmflabs.org/wiki/MediaInfo:M4
[12:59:55] <stashbot>	 M4: Phabricator project labels - https://phabricator.wikimedia.org/M4
[13:00:09] <DanielK_WMDE>	 what the hell, stashbot
[13:02:11] <Reedy>	 crap regexes
[18:30:42] <Amir1>	 RoanKattouw: Hey, do you have a minute to check https://gerrit.wikimedia.org/r/#/c/434814/ ? It has been thoroughly tested :D
[18:53:31] <no_justification>	 We should get 1.31 out this week..... https://phabricator.wikimedia.org/tag/mw-1.31-release/
[18:59:00] <James_F>	 Amir1: I imagine RoanKattouw will prefer to merge that just /after/ the cut, not just before it. :-)
[19:27:30] <greg-g>	 anomie: ah, I just saw https://phabricator.wikimedia.org/T196379 Looks like that needs to happen on Beta Cluster *now* though, yes? As the db update script is failing on that new code
[19:28:03] <greg-g>	 sorry, just saw your comment
[20:06:51] <Amir1>	 James_F: yeah, It has been sitting there for a while now :/
[20:08:02] <paladox>	 no_justification stable release?
[20:26:15] <no_justification>	 Yes. That
[20:36:48] <paladox>	 ok :)
[21:23:11] <SMalyshev>	 anybody knows if there's an easy way to get from DB://cluster25/342831976 URL to the actual revision text from the command line?
[21:29:18] <Reedy>	 Are you getting that from the archive row?
[21:29:36] <SMalyshev>	 Reedy: from text table
[21:32:02] <Reedy>	 SMalyshev: ExternalStore::fetchFromURL()?
[21:43:21] <paladox>	 Reedy hi, wondering could you review https://gerrit.wikimedia.org/r/#/c/437364/ please? :)
[21:44:10] <Krinkle>	 I'm curious what people's thoughts are on adopting conventions for maintenance script parameters. In particular to make consistent whether "dry run" is the default or how to enable it, and to reject unknown parameters. So that e.g. 'php nukeTheWorld.php --dry-pun' does not nuke the world, like it would now.
[21:45:26] <paladox>	 Reedy question, would this:
[21:45:27] <paladox>	 		return is_array( $key) && ( count( $val ) == 3 )
[21:45:27] <paladox>	 			? [ $val[0], $val[1] ]
[21:45:27] <paladox>	 			: [ null, null ];
[21:45:29] <paladox>	 work?
[21:46:01] <Reedy>	 No
[21:46:23] <paladox>	 hmm
[21:47:29] <paladox>	 Reedy which way would you do it so it's not duplicated?
[21:47:40] <Reedy>	 Look at what you pasted
[21:48:10] <SMalyshev>	 Reedy: thanks, will try that. No CLI tool?
[21:49:02] <Krinkle>	 SMalyshev: Does 'echo .. | mwscript eval.php --wiki' count as a CLI tool? :D
[21:49:04] <SMalyshev>	 Krinkle: dry run for nuke-the-world scripts makes sense, for others maybe not so much
[21:49:06] <Reedy>	 Nope... eval.php would be closest
[21:49:20] <paladox>	 return !is_array( $key) ? [ null, null ] : [ $val[0], $val[1] ];
[21:49:21] <SMalyshev>	 Krinkle: maybe :) I didn't think about eval, will try it
[21:49:22] <paladox>	 reedy ^^
[21:50:20] <Reedy>	 paladox: You're dirtying the diff by inverting it unnecessarily. You're losing the check that's already there and you're doing an is_array() on something that'd never be an array
[21:50:56] <paladox>	 hmm
[21:56:49] <Krinkle>	 Reedy: btw, https://phabricator.wikimedia.org/T196185 doesnt' cherry-pick cleanly. I can land it if you draft one :)
[21:57:14] <Reedy>	 Why me? ;P
[21:57:32] <Reedy>	 Cherry pick to what?
[21:58:59] <Krinkle>	 Oh, I misread Lego as Reedy
[21:59:03] <Krinkle>	 I don't... know.
[21:59:10] <Reedy>	 That's... a new one :P
[21:59:10] <legoktm>	 o.O
[21:59:19] <Reedy>	 Krinkle: You know what I was saying about getting your eyes tested...
[21:59:31] <legoktm>	 But yes, I'll put up a manual cherry-pick
[21:59:33] <Krinkle>	 x.x
[21:59:46] <Krinkle>	 □.□
[21:59:50] <Krinkle>	 Indeed.
[22:06:46] <legoktm>	 Krinkle: release notes in 1.31 are out of sync with master I think. anyways, https://gerrit.wikimedia.org/r/437368
[22:07:54] <Krinkle>	 legoktm: hm.. thats not good. Is it just one commit forgotten to backport, or should we sync notes separately?
[22:08:44] <legoktm>	 https://paste.fedoraproject.org/paste/nY6j63mnuNDIKtxw4CT-3A
[22:09:29] <legoktm>	 <wikibugs_> (PS1) Legoktm: Sync RELEASE-NOTES-1.31 with REL1_31 [core] - https://gerrit.wikimedia.org/r/437370
[22:09:53] <legoktm>	 I think people added rel notes directly to 1.31 instead of doing it in master first and then cherry-picking
[23:42:31] <no_justification>	 legoktm: I also think a manually curated Release Notes file is rather antiquated :\
[23:43:25] <Reedy>	 heh
[23:43:57] <legoktm>	 probably
[23:54:02] <legoktm>	 MaxSem: I started looking, but I wasn't able to find any HHVM bug report for the issues with variadic params
[23:54:39] <MaxSem>	 apparently, it's related to PHPUnit itself
[23:55:11] <MaxSem>	 in any case, just another reason to drop HHVM support the second WMF migration is complete
[23:56:45] <MaxSem>	 I can haz review of https://gerrit.wikimedia.org/r/405374 before it conflicts again?
[23:58:07] <legoktm>	 I can't think of any reason to keep CryptRand around... (after deprecation policy is fullfilled)