[06:56:28] <legoktm>	 MaxSem: hmm, phan is failing all over the place due to wfMessage()
[06:56:29] <legoktm>	 https://integration.wikimedia.org/ci/job/mwext-php70-phan-docker/7638/console
[14:46:36] <addshore>	 tgr: Right, I think to effectively do this testing I really need a list of stuff that daniel is most concerned about.
[14:46:57] <addshore>	 I'v been around testing some things, and started writing a few more browser tests, but still not sure where I should further expand
[16:23:24] <addshore>	 DanielK_WMDE_: o/
[16:23:39] <addshore>	 I did some more testing today, and a more review, and some screwing around with selenium tests
[16:56:04] <hasharAway>	 anomie: hello. I have stated it in another channel:  you are a true mediawiki hero :]
[16:56:47] <hasharAway>	 I love how you figured out that background jobs ends up sending / resetting sessions somehow (  https://phabricator.wikimedia.org/T191537#4143301  ) :]
[17:03:53] <greg-g>	 now I have https://www.youtube.com/watch?v=EqWRaAF6_WY in my head
[17:04:30] <anomie>	 hasharAway: Thanks (:
[17:45:58] <legoktm>	 anomie: I think https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/438281/ should fix it
[17:48:45] <Reedy>	 oh god
[17:48:49] <Reedy>	 have the urls changed with the upgrade?
[17:48:57] <paladox>	 yes
[17:49:00] <paladox>	 for notedb
[17:49:11] <paladox>	 though the old url is still supported
[17:49:18] <paladox>	 https://gerrit.wikimedia.org/r/#/c/438281/
[17:58:27] <greg-g>	 Reedy: CHANGE!
[17:58:27] <legoktm>	 anomie: should I just remove the link then?
[17:58:32] <greg-g>	 Reedy: :P
[17:59:07] <anomie>	 legoktm: Probably. I tried to find somewhere in the actual documentation that specified it, but I didn't see anything mentioning it at all.
[17:59:08] * Reedy slaps greg-g
[17:59:50] <legoktm>	 ok, removed
[18:01:25] <legoktm>	 https://github.com/squizlabs/PHP_CodeSniffer/issues/1652#issuecomment-348062174
[18:03:20] <legoktm>	 anomie: I don't know how authoritative https://github.com/phpDocumentor/fig-standards/issues/121#issuecomment-168749811 is, but that's what PHPCS ended up following https://github.com/squizlabs/PHP_CodeSniffer/issues/841#issuecomment-168823185
[18:06:02] <anomie>	 legoktm: +2ed
[18:06:12] <legoktm>	 thanks :)
[18:23:34] <James_F>	 Reedy: Also don't worry, the old URLs redirect (e.g. https://gerrit.wikimedia.org/r/#/c/425837/ -> https://gerrit.wikimedia.org/r/#/c/mediawiki/services/mobileapps/+/425837/)
[18:31:09] * paladox waits for the notedb to switch it's self to on mode for the hashtag mode and cc feature and the fact you can tell who adds you as a reviewer now.
[18:33:01] <legoktm>	 it's like Zawinski's law, but except with hashtags
[18:33:55] <hashar>	 anomie: setting $wgJobRunRate = PHP_INT_MAX;  seems to fix the session issue :-]
[18:34:19] <hashar>	 guess I will polish up a patch next week and maybe try to write a test that reproduce the problem
[18:34:31] <paladox>	 legoktm heh
[18:34:45] <anomie>	 hashar: That does hint that we're right about the cause then.
[18:35:06] <paladox>	 oh and once notedb switches to on, we can all use emojie's
[18:35:28] <hashar>	 anomie: oh for that I was sure you were right, I have no doubt about your mediawiki knowledge.  I have spent a good part of the afternoon to redig in the log by myself to make sure I understood the issue properly :]
[18:36:09] <hashar>	 anomie: surely the deferred job emitting a cookie from another session is a nasty bug in mediawiki itself.  But as you said, it is probably a lot of work to figure it out properly
[18:42:52] <paladox>	 you can also view other users dashboards too now!
[18:42:53] <paladox>	 https://gerrit.wikimedia.org/r/dashboard/legoktm@member.fsf.org
[18:43:02] <legoktm>	 :o
[18:43:08] <legoktm>	 > The page you requested was not found, or you do not have permission to view this page.
[18:43:31] <paladox>	 heh that's gwtui
[18:43:36] <paladox>	 polygerrit is what you need :)
[18:43:42] <paladox>	 it's also mostly complete now
[18:43:43] <paladox>	 in 2.15
[18:44:28] <paladox>	 also no one can have hidden changes so it's now all open :)
[18:44:56] <paladox>	 also you can set your change to WIP mode
[18:50:51] <MaxSem>	 legoktm, re phan: huh
[18:51:17] <MaxSem>	 at this point I say make it mixed and file a bug against Phan:P
[18:53:24] <legoktm>	 MaxSem: I fixed it with https://gerrit.wikimedia.org/r/438281
[18:53:54] <MaxSem>	 danke
[23:55:15] <paladox>	 legoktm it works now :)
[23:55:17] <paladox>	 https://gerrit.wikimedia.org/r/dashboard/legoktm@member.fsf.org
[23:55:38] <paladox>	 well wow