[12:02:37] MatmaRex_: So maybe.... "I care, but not enough to vocalize an opinion so don't ask" [12:02:48] Or, "I'm keeping my mouth shut" [12:03:09] i am missing context here [12:03:13] ?? [12:03:34] Diff between CC and reviewers [12:03:38] I just now saw timestamps [12:03:39] :) [12:03:46] oh, i see. heh, yeah [12:47:42] i think it removes it from your dashboard [12:47:52] but upstream added a new cc'ed on section [13:55:28] in theory you could make queries for which changesets have no reviewers, and being on CC would not interfere with that [13:55:39] in practice I doubt it will be used [13:55:48] hashtags, though! [13:56:19] also apparently it detects things like [WIP] in the summary? [13:56:39] there is a separate "work in progress" section on the dashboard [13:58:14] tgr you have to use the wip button for it to go in that section :) [14:35:03] paladox: I see, thanks. [14:35:11] your welcome :) [14:35:32] tgr google has more mocked ui's for pg [14:35:33] https://docs.google.com/presentation/d/1xOwLICLyDuK8jQYiu6I2Wu0aF0AWCMsnXMqQNz0Kmhw/edit#slide=id.g365f09a753_0_282 [14:35:43] btw do you know how the patchset description thingie works? [14:35:57] sometimes I can edit that, sometimes I cant [14:36:06] havent found any logic to it so far [14:36:06] yep [14:36:14] on the file bar [14:36:30] there should be [14:36:34] "Add patchset description" [14:36:43] you click that and enter a description [14:36:51] i think only the owner of the change can do that [14:36:54] yeah, sometimes. [14:37:00] other times there's just "No patchset description [14:37:34] in some cases I am the owner of both the whole changeset and the last patchset and still can't edit it [14:37:40] hmm [14:38:40] maybe it's limited to changesets that were created since the 2.14 upgrade? [14:38:44] tgr i guess it's this https://github.com/GerritCodeReview/gerrit/blob/4a467ce13e139aefa620c28073ba421320c79369/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js#L106 [14:39:38] tgr all patch set should work i think. [14:39:44] which ones are you having problems with? [14:43:07] oh https://github.com/GerritCodeReview/gerrit/commit/27d0477077b3b9e205953bde953d477e4b3864d3#diff-85b1092c1221f50070e074a307173757 [14:44:16] tgr ^^ [14:44:20] i think i found a bug [14:44:23] found the bug [14:46:23] maybe I was just confused about which changesets I was the original uploader of, I can't find any example right now [14:46:42] I'll see if I stumble upon one [14:47:20] ok [14:47:25] that said, it would really make more sense to let both the changeset owner and the author of the patchset to change the description [14:48:56] im back porting the fix [14:52:15] tgr https://gerrit-review.googlesource.com/c/gerrit/+/183911 [14:56:18] tgr hmm maybe that won't fix your issue but it fixes another issue [14:56:28] since that fixes _handleDescriptionChanged