[02:02:54] <legoktm>	 https://phabricator.wikimedia.org/tag/mw-1.31-release/ 
[02:02:55] <legoktm>	 o/
[02:02:58] <legoktm>	 \o/*
[13:37:18] <tgr>	 DanielK_WMDE: I am making a list of hook calls, to make a test plan
[13:38:18] <tgr>	 one thing I noticed is that some extension comments say "we call RevisionInsertComplete instead of PageContentSaveComplete <for whatever reason>"
[13:38:20] <DanielK_WMDE>	 tgr: cool, thank you! I'm rebasing stuff and writing more unit tests.
[13:38:33] <tgr>	 but RevisionInsertComplete does not seem to be called anymore
[13:38:35] <DanielK_WMDE>	 tgr: i wonder if we should rebase the RevisionStore patches on top of the PageUpdater patch.
[13:38:39] <DanielK_WMDE>	 they are technically unrelated.
[13:38:54] <DanielK_WMDE>	 but we'll want to have all of them on the test branch
[13:39:12] <tgr>	 no need if they cherry-pick cleanly
[13:39:37] <DanielK_WMDE>	 i'll check
[13:39:44] <tgr>	 otherwise, you need to do the rebasing at some point anyway so better do it now
[13:40:04] <DanielK_WMDE>	 hm... our plan says we want to test PageUpdater and RevisionStore separately. I'm tempted to do it at once. what do you think?
[13:40:44] <tgr>	 in general testing things together saves a fair amount of time, if we think both are ready
[13:41:13] <tgr>	 it's easy to check out one or the other separately when something breaks
[13:41:47] <DanielK_WMDE>	 yep
[13:41:51] <tgr>	 so anyway, RevisionInsertComplete seems to be replaced with RevisionRecordInserted with no B/C?
[13:42:00] <DanielK_WMDE>	 hm, there is one conflict in the cherry-pick
[13:42:03] <DanielK_WMDE>	 i'll look into that
[13:54:49] <DanielK_WMDE>	 ok, conflict removed. 
[13:55:09] <DanielK_WMDE>	 by just undoing the relevant change. I don't know what that was about anyway :P
[13:57:23] <DanielK_WMDE>	 next fixing linter errors
[14:16:28] <paladox>	 tgr i've started the work to get gerrit to use avatars https://gerrit.wikimedia.org/r/c/operations/puppet/+/439783 and https://gerrit.wikimedia.org/r/c/operations/puppet/+/439808
[14:18:23] <tgr>	 cool
[18:47:10] <paladox>	 php 7.3 alpha 1 was released this week and first benchmark shows it has improved in performance https://www.phoronix.com/scan.php?page=news_item&px=PHP-7.3-Alpha-1-Benchmarks
[18:55:52] <Reedy>	 We're not going to be running it any time soon
[18:56:04] <Reedy>	 And as we've said before... Benchmark != real world performance
[21:13:14] <AaronSchulz>	 Reedy: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/439778/ tiny review plz ?