[10:32:13] <tgr>	 DanielK_WMDE: I have a test plan at https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/MCR-StorageLayerTesting#PageUpdater_test_plan (feel free to add stuff), I could go through that today and merge the PageUpdater patch, unless we want to add more patches to be tested
[10:32:29] <tgr>	 is there anything worth adding apart from RevisionStore?
[11:20:28] <DanielK_WMDE>	 tgr|away: just the two RevisionStore patches
[11:21:42] <DanielK_WMDE>	 tgr|away: re merge: please hold back on that, we want these patches on a separate branch first that will then go to test.wikipedia.org but not other wikis. at least that's the plan addshore made with releng. let's dicuss this during the checkin tomorrow
[11:21:50] <addshore>	 o/
[11:21:58] <DanielK_WMDE>	 hey
[11:23:32] <addshore>	 are some of them almost ready to be merged then? :D
[11:24:00] <addshore>	 I'll be switching to MCR stuff at some point today, so I can follow up with releng this evening if I have a list of patches that are ready
[11:24:21] <DanielK_WMDE>	 afaik all three big patches are ready to be merged after they have passed all the tests.
[11:24:47] <DanielK_WMDE>	 we'll want to check them on wmflabs, then make a branch to go on testwiki, right?
[11:24:51] <DanielK_WMDE>	 when would that be deployed?
[11:25:10] <DanielK_WMDE>	 having them on testwiki next wee would be nice
[11:25:21] <DanielK_WMDE>	 (with MIGRATION_OLD)
[11:25:26] <addshore>	 awesome, so, just to make sure i don't get confused lets link those patches on the ticket somewhere
[11:25:51] <DanielK_WMDE>	 will do. another round of reviews and a +1 would be appreciated, too
[11:25:57] <addshore>	 so, the initial plan was going to be deploy it this thursday evening to test after the regular train slot
[11:26:11] <DanielK_WMDE>	 Thursday the 14th?
[11:26:14] <addshore>	 as next week is a no deploy week they can just sit there then
[11:26:17] <DanielK_WMDE>	 i.e. tomorrow?
[11:26:20] <addshore>	 DanielK_WMDE: yes :P
[11:26:47] <DanielK_WMDE>	 ok, then means we really want to try all three patches on wmflabs today :)
[11:26:56] <addshore>	 otherwise we wait until the week of the 25th
[11:28:22] <DanielK_WMDE>	 no, let's get this done now if possible
[11:28:24] <DanielK_WMDE>	 tgr|away: --^
[11:28:42] <DanielK_WMDE>	 addshore: can you have a lok at this one soon? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/439966
[11:28:55] <DanielK_WMDE>	 this would unblock CI for MIGRATION_WRITE_BOTH mode
[11:29:43] <addshore>	 DanielK_WMDE: that can be on my list for today
[11:29:50] <DanielK_WMDE>	 yay!
[11:30:20] <addshore>	 DanielK_WMDE: can you explicetly link me to the 3 big patches we want in then? just so there is no missunderstandings :)
[11:31:21] <DanielK_WMDE>	 addshore: https://www.mediawiki.org/w/index.php?title=User:Daniel_Kinzler_(WMDE)/MCR-StorageLayerTesting&summary=%2F%2A+top+%2A%2F+#WMF_deployed_extensions
[11:31:47] <addshore>	 patches listed at the top, sweet
[11:32:12] <DanielK_WMDE>	 eww, VE makes the URL ugky
[13:04:14] <DanielK_WMDE>	 tgr|away, addshore: I'll cherry-pick the three relevant patches onto mcr-full
[13:04:37] <hashar>	 DanielK_WMDE: Guten tag. If you got time today it would be nice to get a final review on anomie patch to disable cookie/headers sent by jobs :D https://gerrit.wikimedia.org/r/c/mediawiki/core/+/439289
[13:06:17] <tgr>	 DanielK_WMDE: thx! I'm on and off for a while, will do the testing in the evening
[13:15:57] <DanielK_WMDE>	 tgr: how do i become mwvagrant?
[13:16:26] <DanielK_WMDE>	 i can't do git suff as myself
[13:16:45] <DanielK_WMDE>	 oh, found it, sry
[14:01:39] <tgr>	 I just sudo -u usually
[14:05:18] <DanielK_WMDE>	 tgr: i have all three changes cherry-picked on mcr-full now
[14:05:42] <DanielK_WMDE>	 tgr: also https://phabricator.wikimedia.org/T192306#4279237
[14:05:49] <DanielK_WMDE>	 if we both do manual testing, let's coordinate
[14:06:30] <DanielK_WMDE>	 maybe having this on phab isn't useful... grabbing chunks and tracking progress on-wiki may be better
[14:08:20] <DanielK_WMDE>	 tgr: https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/MCR-StorageLayerTesting#Daniel_will_do
[15:20:34] <DanielK_WMDE>	 tgr: do you plan to do manual testing today? addshore said we could have this on testwiki tomorrow...
[15:22:01] <tgr>	 yeah, in an hour or so
[15:22:38] <tgr>	 I'm working until midnight-ish today, I should be able to go through all of it
[15:25:52] <no_justification>	 Last call on 1.31.
[15:26:04] <no_justification>	 legoktm, Krinkle, James_F, tgr, DanielK_WMDE
[15:26:40] <James_F>	 Go go go.
[15:31:00] <no_justification>	 What do I do to release notes again?
[15:31:49] <no_justification>	 Oh yeah, just remove that top bit
[15:32:12] <no_justification>	 Only been gone a week and already I'm rusty
[15:34:42] <no_justification>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/440143 PLZ REVIEW FOLKS
[15:34:48] <no_justification>	 So I can make ze tag
[15:39:27] <DanielK_WMDE>	 no_justification: I already miss you ;)
[15:45:09] <no_justification>	 I haven't even left IRC!
[15:45:10] <no_justification>	 <3
[16:15:04] <James_F>	 no_justification: Swap: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/440161
[16:23:42] <no_justification>	 +2
[16:24:01] <no_justification>	 I'll issue the 1.31.0 tag when I'm back at my desk in a minute 
[16:54:33] <addshore>	 DanielK_WMDE: i can do more later this evening, but not right now, got to dash
[16:55:13] <DanielK_WMDE>	 addshore, tgr: let's use the wiki page to coordinate
[16:55:29] <DanielK_WMDE>	 i'm through with other stuff, i'll do another hour of manual tests in a minute. need some air first
[17:11:57] <no_justification>	 https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/1.31.0
[17:12:05] <no_justification>	 Published the tag, will generate tars
[17:17:25] <no_justification>	 James_F: I tried out `git-archive-all`
[17:17:27] <no_justification>	 It Just Works
[17:17:28] <no_justification>	 :D
[17:18:16] <no_justification>	 We should use it for 1.32 :D
[17:24:41] <no_justification>	 Tars uploading to releases.wikimedia.org
[17:25:25] <no_justification>	 https://releases.wikimedia.org/mediawiki/1.31/ - if someone wants to download & verify :)
[17:25:28] <James_F>	 no_justification: Nice.
[18:04:56] <DanielK_WMDE>	 tgr: this has been going very nicely so far! But I didn't touch any extensions yet...
[18:06:06] <tgr>	 DanielK_WMDE: I think the ones under https://www.mediawiki.org/wiki/User:Daniel_Kinzler_(WMDE)/MCR-StorageLayerTesting#RevisionInsertComplete will break, that hook effectively went away
[18:06:17] <tgr>	 did not test yet though
[18:08:43] <DanielK_WMDE>	 tgr: oh, good point - though this is already the case on master!
[18:09:01] <DanielK_WMDE>	 ...and has been since january?...
[18:10:53] <DanielK_WMDE>	 tgr: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventBus/+/407863
[18:11:41] <DanielK_WMDE>	 I see... since most code is still calling the old method on Revision, the hook still gets called.
[18:12:29] <DanielK_WMDE>	 but with PageUpdater, this changes. So the hook will no longer be called.
[18:13:33] <tgr>	 yeah, I think it would be nice to have a B/C call from the new hook
[18:13:41] <tgr>	 or are they not quite compatible?
[18:13:45] <DanielK_WMDE>	 tgr: this is easy enough to fix, but I'm not sure where to best fix it. conceptually in the PageUpdater patch. but it's conging to conflict with the RevisionStore patches.
[18:14:27] <DanielK_WMDE>	 they are compatible enough...
[18:16:09] <DanielK_WMDE>	 tgr: i'll make a separate patch. it's going to conflict though. will sort that out tomorrow. i was about to leave the office
[18:20:20] <tgr>	 DanielK_WMDE: yeah, I'd just make a separate patch, test it like that, squash into the PageUpdater patch (if that's the right place for it) before it gets merged to master
[18:21:03] <DanielK_WMDE>	 tgr: but that makes teh PageUpdater patch conflict with the RevisionStore patches... maybe. Maybe not.
[18:21:18] <DanielK_WMDE>	 https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/440176
[18:21:36] <DanielK_WMDE>	 tgr: good catch, thanks!
[18:21:44] <DanielK_WMDE>	 I'm off for now, will be back for techcom later
[18:26:45] <Isarra>	 Yo how do you nominate people for +2 for mw in general?
[18:26:57] <Isarra>	 Who do I ask?
[18:27:15] <Isarra>	 ...does the fact that I don't know mean I shouldn't be nominating people for that sort of thing?
[18:27:40] <Isarra>	 (Yes, I know it's not actually you guys, but I bet you... care. >.>)
[18:27:43] <Reedy>	 The first rule of the mw +2 cabal...
[18:35:45] <Isarra>	 FINE. I'LL GO KIDNAP LEGOKTM.
[18:49:18] <Niharika>	 Isarra: Probably just create a ticket and start an email thread. 
[18:49:59] <Niharika>	 Isarra: Also, do you wanna talk to Moriel about OOUI and/or Echo?
[18:53:31] <Isarra>	 YES. But not right now deadline ack.
[18:53:47] <Isarra>	 ...she said by noon I have six minutes. >.>
[18:53:56] <Isarra>	 (She being someone else entirely.)
[20:01:41] <anomie>	 Isarra: As far as I can tell, the "how" is to file a Phab task like https://phabricator.wikimedia.org/T197070 and then email wikitech-l to announce it. See also https://www.mediawiki.org/wiki/Gerrit/Project_ownership#Requesting_repository_ownership
[20:15:28] <legoktm>	 no_justification: yaaaaay
[20:16:14] <legoktm>	 Isarra: what anomie said. Though usually I ask a few other +2'ers first as a sanity check (do you think this person would be a good +2'er?) before nominating people
[20:26:04] <no_justification>	 Should probably write the e-mail for it
[20:27:18] <legoktm>	 no_justification: the diff between rc.2 and 1.31.0 looks good to me
[20:29:36] <Isarra>	 anomie: <3
[20:29:41] <Isarra>	 legoktm: I'll kidnap you, then.
[20:30:43] <legoktm>	 good luck, I'm about to get on a plane ;)
[20:30:59] * legoktm -> ✈️
[20:37:58] <no_justification>	 Isarra: I'd not recommend hijacking that plane either.
[20:38:33] <Isarra>	 Eh, much easier to nab specific people in an airport.
[20:38:40] <Isarra>	 They're at their most vulnerable there.
[20:38:50] <Isarra>	 ON the plane, they're not toting around piles of luggage...
[21:24:26] <c>	 updated news link
[21:24:32] <c>	 took a few clicks for me to find it >_>
[21:24:40] <c>	 too many transclusions