[09:13:06] <tgr>	 how is https://gerrit.wikimedia.org/g/mediawiki/core/+/master/languages/classes/LanguageEn.php#84 supposed to work? that object has no hook callback
[09:29:42] <DanielK_WMDE>	 mobrovac: hey! what time zone are you in atm?
[09:30:23] <DanielK_WMDE>	 tgr: it doesn't. It's broken.
[09:30:34] <DanielK_WMDE>	 I filed a bug about this a while ago, let me find it
[09:32:49] <DanielK_WMDE>	 tgr: hm. can't find it. but yes: it's broken. 
[10:45:03] <Reedy>	 tgr: lol, it's been like that since it was created
[10:52:03] <Reedy>	 https://gerrit.wikimedia.org/r/441370 just removes it
[15:04:51] <Reedy>	 https://twitter.com/bercut2000/status/1009709520220803072 heh
[15:38:40] <bd808>	 Reedy: that diagram is perfect!
[16:25:22] <subbu>	 ha ha .. that is funny!
[16:26:50] <DanielK_WMDE>	 tgr: this mess about $baseRevId is a verz good example for how important good naming is.
[16:27:28] <_joe_>	 bd808: no a realistic diagram would've had a horn in place of the mute button, and a "#ugly hack" near to the volume buttons
[16:27:31] <_joe_>	 :P
[16:27:52] <_joe_>	 because code comments are always outdated and self-apologetic :D
[16:28:09] <_joe_>	 I found some time ago a piece of code where I wrote in a comment
[16:28:23] <_joe_>	 # Forgive me, my future self. 
[16:28:54] <_joe_>	 I knew already I'd read that code in a couple years and think "who's the sloppy moron who did this horrible hack?"
[16:28:58] <bd808>	  // FIXME No time to do this right
[17:04:48] <tgr>	 DanielK_WMDE: re: undo-failure, I think that message is meant for the case when you try to undo the diff between oldid1 and oldid2 and it does not apply cleanly to the current revision
[17:05:30] <tgr>	 which is probably the only way you can get an undo failure in wikitext
[17:06:06] <DanielK_WMDE>	 tgr: probably, i should double check... can you put that on the ticket?
[17:06:09] <DanielK_WMDE>	 i need to run now
[17:06:11] <DanielK_WMDE>	 thanks!
[17:06:13] <tgr>	 sure
[17:06:28] <DanielK_WMDE>	 ...on the patch, i mean