[11:15:20] <DanielK_WMDE_>	 tgr: I went for $originalRevId now. Thanks for unearthing more of the actual meaning of this thing :)
[11:19:59] <DanielK_WMDE_>	 I updated https://phabricator.wikimedia.org/T197685 accordingly
[11:59:38] <tgr>	 DanielK_WMDE_: tweaked the description a bit, will merge if you are OK with it
[12:54:13] <DanielK_WMDE_>	 tgr: yes, thanks - i totally forgot to update the commit message...
[12:54:58] <DanielK_WMDE_>	 anomie: can this go in now? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/426009
[14:20:08] <legoktm>	 Krinkle, James_F: It's unclear to me after reading https://www.mediawiki.org/wiki/Deprecation_policy#Scope whether RL module *names* (like the mw.api.foo -> mw.api changes) are in scope or not
[14:21:06] <Krinkle>	 legoktm: I'd say strictly speaking (given it says JS is not in scope) not, although I'm surprised by that.
[14:21:26] <legoktm>	 I don't think it would be a stretch to consider them part of the PHP API that mw provides in the context of addModules/addModuleStyles, but yeah, that.
[14:21:35] <James_F>	 Huh.
[14:21:53] <Krinkle>	 Yeah, but these aren't changes to the addModules() contract.
[14:22:02] <legoktm>	 mhm
[14:22:04] <Krinkle>	 And they don't have soft/hard deprecation etc. this is quite PHP specific indeed.
[14:22:27] <Krinkle>	 But we should have a policy for it, and lacking another one, I have been following the same semantics as closely as possible.
[14:22:41] <Krinkle>	 legoktm: Is there a particular issue where you're wondering about what (not) to do?
[14:23:23] <legoktm>	 No, I was skimming through bug mail and saw https://phabricator.wikimedia.org/T192623#4306898
[14:23:40] <James_F>	 Yeah.
[14:23:56] <James_F>	 We generally follow the deprecation policy for JS anyway.
[14:24:08] <James_F>	 If anything, we’re a lot slower than the policy.
[14:24:35] <James_F>	 The wikibits code is deprecated since 1.17 and still not removed. :-(
[14:30:17] <legoktm>	 I started a discussion at https://www.mediawiki.org/wiki/Topic:Ufj4hr8yjtpuyhrg
[15:26:51] <davidwbarratt>	 so... uhhh... it looks like in a TablePager implementation (or IndexPager for that matter), you can't mutate the rows (within the $result) object in  preprocessResults ?
[15:37:36] <bd808>	 anomie: running a little bit late
[15:37:42] <anomie>	 bd808: ok
[15:37:56] <bd808>	 Hopefully 3 more minutes...