[13:57:20] <Krinkle>	 DanielK_WMDE: Thought re NameTableStore signature? https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/441340/2/includes/ServiceWiring.php
[14:02:29] <DanielK_WMDE>	 Krinkle: my preferred approach is having a separate subclass for each table.
[14:02:34] <DanielK_WMDE>	 No messy constructor, better type safety
[14:03:31] <DanielK_WMDE>	 also, unit tests for the "special" behavior
[14:03:49] <Krinkle>	 How would the subclass set these parameters?
[14:05:06] <DanielK_WMDE>	 Krinkle: the callbacks wound't be parameters.
[14:05:20] <DanielK_WMDE>	 they would be protected stub methods.
[14:05:32] <DanielK_WMDE>	 the rest would stay as it is.
[14:35:36] <DanielK_WMDE>	 legoktm: better now? se PageUpdater to create dummy revisions. 
[14:35:40] <DanielK_WMDE>	 err.
[14:35:44] <DanielK_WMDE>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/403879
[15:13:14] <greg-g>	 DanielK_WMDE: addshore all well with the wmf.999 branch?
[15:13:20] <addshore>	 o/
[15:13:35] <addshore>	 greg-g: yup, I did another scan of the logs an hour or so ago and couldn't spot anything bad happening
[15:13:55] <greg-g>	 cool
[15:14:44] <greg-g>	 thanks :)