[00:10:10] <James_F>	 Reedy: Hmm. Re. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/443358 is it really worth keeping and deprecating that method?
[00:10:21] <Reedy>	 We can remove it later ;)
[00:10:27] <James_F>	 Or… now. :-)
[00:10:42] <James_F>	 Also https://gerrit.wikimedia.org/r/c/mediawiki/core/+/443357 :-)
[00:11:45] <James_F>	 Thanks!
[00:30:36] <Reedy>	 tidy still needs removing from servers ;P
[00:33:00] <bd808>	 Reedy: probably enough just to stop installing it via modules/mediawiki/manifests/packages.pp ?
[00:33:36] <Reedy>	 I guess we still need it on CI?
[00:34:34] <bd808>	 probably for a while anyway. I'd bet that donationwiki still needs it
[00:34:46] <bd808>	 (or whatever its called)
[00:35:33] <Reedy>	 hmm
[00:35:33] <Reedy>	 	'foundationwiki' => false,
[00:35:34] <Reedy>	 	'collabwiki' => false,
[00:35:34] <Reedy>	 	'donatewiki' => false,
[00:36:02] <Reedy>	 So tidy isn't actually still tidy?
[00:36:57] <legoktm>	 most of CI should not be using the puppet roles anymore
[00:38:11] <Reedy>	 Based on DefaultSettings.php having $wgTidyConfig = [ 'driver' => 'RemexHtml' ];
[00:38:17] <Reedy>	 I'm guessing CI isn't using it either
[00:38:24] <legoktm>	 it uses it for older branches
[00:38:28] <legoktm>	 everything pre-1.31
[00:38:34] <Reedy>	 boo
[00:54:26] <subbu>	 We should keep tidy around on servers for a month or two while wikis continue fixing their pages and templates .. and in case they need to see how it looked with Tidy .. ParserMigration needs to support it.
[05:22:30] <Krinkle>	 legoktm: I forgot whether we ended up doing  https://phabricator.wikimedia.org/T186315#3977149
[05:22:36] <Krinkle>	 I recall something vaguely, but not sure..
[07:35:19] <Krinkle>	 brion: is “CPU per CPU” on the VP9 Migration Page a typo? Didn’t quite understand that sentence.
[13:20:08] <DanielK_WMDE>	 anomie: i re-opened this, since I think the tables are still missing from the live databases: https://phabricator.wikimedia.org/T183486#4411867
[13:20:18] <DanielK_WMDE>	 I may be wrogn, but I think we never re-created them
[13:21:36] <DanielK_WMDE>	 (also, I *cough* forgot the passphrase for my ssh key for production *cough*... I guess I don't use that enough...)
[13:21:41] <anomie>	 DanielK_WMDE: slots exists on enwiki. I'll run through and check all other wikis later.
[13:22:10] <DanielK_WMDE>	 anomie: ok, thanks. i just checked SAL, and didn't see any mention of the tables being re-created after we dropped them in Apil.
[13:22:33] <DanielK_WMDE>	 if they exist, just close the ticket again, and stike it out in the table.
[13:22:35] <DanielK_WMDE>	 thanks!
[13:23:12] <anomie>	 DanielK_WMDE: https://wikitech.wikimedia.org/wiki/Server_admin_log/Archive_34#2018-04-20 at 13:35?
[13:27:40] <DanielK_WMDE>	 anomie: uh... i guess my brain wasn't working when I looked at that earlier?...
[14:29:31] <Reedy>	 14:22:53 Destructor threw an object exception: exception 'MWException' with message 'AbuseFilterParserTest::tearDown() must call parent::tearDown()' in 
[14:47:16] <anomie>	 DanielK_WMDE: Let me know if you want to make any changes based on my comment on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/444893/1, or if I should go ahead and +2 them as-is.
[14:48:30] <DanielK_WMDE>	 anomie: I don't. I prefer the first patch to be independent of the second, just documenting the problematic query.
[14:49:08] <anomie>	 ok then, +2ing
[14:50:26] <DanielK_WMDE>	 thank you
[14:50:48] <DanielK_WMDE>	 if you have a few more minutes for reviews, could you also have a look at the RevisionStoreFactory thing again? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/443985
[15:34:48] <legoktm>	 Krinkle: it hasn't happened yet
[15:35:24] <legoktm>	 Krinkle: my short-term priority w/r to phan is upgrading to a modern version first before cleaning up other things btw
[16:47:56] <anomie>	 DanielK_WMDE_: On the MCR Schema Migration Plan spreadsheet, why do you have some cells with a green background color?
[16:49:10] <bd808>	 The FR Tech folks could use some help figuring out T198869
[16:49:11] <stashbot>	 T198869: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages - https://phabricator.wikimedia.org/T198869
[16:49:24] <bd808>	 they think it mihgt be related to recent MCR changes
[16:50:09] <DanielK_WMDE_>	 anomie: these are "ready". currently, they avan all have patches. But green is inteded to indicate the cells that are not blocked.
[16:55:58] <paladox>	 hi, im wondering what does this func doGetFileStat return? can it be used in filemtime ?
[17:19:01] <Reedy>	 Anyone want to review a simple patch to ContactPage to make a form require users to be logged in?
[17:20:12] <Reedy>	 https://gerrit.wikimedia.org/r/444916
[18:27:00] <DanielK_WMDE_>	 anomie: good catch re the SCHEMA_COMPAT constants not yet being deployed. In my mind, that had already happened.
[18:27:40] <DanielK_WMDE_>	 i pushed back the schedule, to start next week instead of this week
[18:28:04] <anomie>	 I was about to merge and deploy it, good thing I checked.
[18:28:37] <anomie>	 I note that unless someone else takes over some of the deploying while I'm on vacation everything showing week 31 or later will probably be pushed back 3 weeks.
[18:29:53] <DanielK_WMDE_>	 yea, i thought the patch was merged over the weekend, and deployed with the train?... I guess I was confused.
[18:30:13] <anomie>	 It's being deployed with the train, but the train won't finish until Thursday.
[18:30:50] <DanielK_WMDE_>	 oh, right. I need to get more used to the rhythm of this ;)
[18:31:02] <DanielK_WMDE_>	 I can pick up in week 31. or tgr, maybe... I don't remember when he's out.
[18:31:35] <DanielK_WMDE_>	 maybe i could even borrow some hours from adam again. this doesn't take much time in terms of development. 
[18:31:38] <DanielK_WMDE_>	 none, hopefully
[18:33:38] <tgr>	 I'm back on July 25
[18:33:43] <tgr>	 so middle of week 30
[18:33:48] <DanielK_WMDE_>	 anomie: we could still do "write-old, read-old" on friday. I'd prefer that to doing it in the same week as "write-both, read-old"
[18:34:16] <DanielK_WMDE_>	 tgr: ok, cool
[18:34:39] <anomie>	 Normally we don't do deploys on Friday, but since this one is a no-op (explicitly setting configuration to the current default) greg-g might ok it.
[18:57:04] <DanielK_WMDE_>	 anomie: Krinkle found somethign I missed https://gerrit.wikimedia.org/r/c/mediawiki/core/+/444939
[18:58:01] <DanielK_WMDE_>	 after fixing the issue re the text table, we might hit it again with revision_comment...
[19:04:33] <hasharDinner>	 any idea where I could find some basic help about loading a resourceloader module from javascript ? :]
[19:06:48] <hasharDinner>	 I am doing:  bar = mw.loader.require( 'ext.MyExtension' ).bar;
[19:06:53] <hasharDinner>	 bar();
[19:06:56] <hasharDinner>	 and it works!
[19:17:13] <MatmaRex>	 hasharDinner: that will work if you already have a dependency on that module. otherwise, use mw.loader.using() instead: https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.loader-method-using
[19:27:26] <hasharDinner>	 MatmaRex: yeah the dependencies are marked in the resource loader definition :]
[19:29:34] <hasharDinner>	 thank you!