[01:48:27] TimStarling: Is CPT willing to own PoolCounter for the purposes of https://www.mediawiki.org/wiki/Developers/Maintainers ? [01:48:35] cq. https://phabricator.wikimedia.org/T178517#4150618 [01:50:35] I guess, if legoktm has been working on it [01:51:29] I know there are plans for improving deployment which we're not involved in, or haven't been so far [01:54:48] yeah, I guess the deployment has mostly been looked after by SRE for as far as it needed looking after. [01:55:06] I honestly don't know, but I've not heard about pc more than maybe once or twice in the past 7 days. [01:55:14] 7 years * [02:09:42] that's a measure of its awesomeness right? [02:30:44] Absolutely! [02:30:55] It just works. [02:31:40] Quite possibly our first microservice? (we can consider memc/mysql as services, but they seem less "micro") [02:34:30] TimStarling: btw, now that you're here :) - wanted to ask about VipsScaler. I couldn't quite figure out whether or not we still need it. It still gets used (despite Thumbor working for pub/priv wikis, and proxied from direct /w/thumb.php use) for UploadStash scaling of temporary files. [02:34:51] But I'm trying to figure out whether those thumbs would work without vips, or whether vips "merely" optimises its performance. [02:35:30] maybe 1 or 2 hits per week, but it's triggered :) [02:35:45] the point of vips was to use less memory, vips was used to avoid hitting memory or image area limits [02:36:03] seems weird to have two separate systems for image scaling, one used twice a week [02:36:36] Right. I think UploadStash does do scaling more often than that, but I guess Vips only kicks in under certain conditions? [02:37:07] We call ImageMagic and rsvg more often than that (from mw that is) [02:37:12] don't have numbers atm [02:37:29] vips was easy to count because it was accidentally uninstalled for a month or so. [02:37:39] just counted the exec errors x( [02:38:30] and before it was uninstalled, it was pointing at the wrong IP, and before that at a unresolvable IP. [02:38:43] https://phabricator.wikimedia.org/T199937/ https://phabricator.wikimedia.org/T199938 / [02:39:30] but ahm.. it sounds like without vips it wouldn't just make certain scales less efficient, they'd hit the limit and thus not work? [04:09:25] yes, the VipsHandler extension hooks BitmapHandlerCheckImageArea in order to override the maximum image area for images which it can scale [04:10:13] so images greater than wgMaxImageArea will immediately fail to scale if vips is turned off [04:19:14] TimStarling: Interesting, and it seems we don't set a maxArea in prod. [04:20:32] png beyond 2e7 and tiff beyond 5e7 is handled by vips. and non-vips max would otherwise be 10e7. [06:53:04] I've been working on PoolCounter? [07:00:39] oh, I suppose so [18:23:23] tgr, I assume that your deprecated properties trait patch is ready to be merged?