[02:28:42] anomie: you can usually tell which sub task is the culprit by the number of minutes it took for the job to fail. [02:28:52] (J/k) [15:23:50] dan, anomie: Please see: https://phabricator.wikimedia.org/T200269 [15:27:01] greg-g: Duplicate of T200072, which already has a patch that someone should review, merge, and backport. [15:27:02] T200072: MCR causes Cognate integration test fails: The given Title does not belong to page ID 2 but actually belongs to 4 - https://phabricator.wikimedia.org/T200072 [15:29:03] anomie: should it block the train or no, given it was separately reported and worked on without that signifier? [15:29:32] greg-g: Up to you. The fix is simple enough and is already done, someone just has to review and merge and so on. [15:29:46] I can't self-review it though. [15:29:48] who can do the review right now? we're up against a clock [15:30:09] Anyone with +2? [15:31:14] theoretically, but who has the needed context for this patch. I presume MCR-related changes have a bit of a learning curve that not everyone has [15:31:43] I guess hashar +1'd [15:32:02] but he's not online [15:32:20] I don't think there's much context needed for this one. But if you want context, tgr|away and addshore are the other people I know of who have context. [15:32:20] greg-g: is a +1 from hashar good enough for us to +2 it? :) [15:32:35] zeljkof: it was more I was hoping he'd be willing to merge it [15:32:41] o/ [15:32:49] addshore: comfortable merging https://gerrit.wikimedia.org/r/c/mediawiki/core/+/447405 ? [15:32:58] addshore: could you please take a look? [15:33:20] last remaining train blocker at the last remaining moment to get the train unblocked before the next train. [15:33:22] in a meeting for the next 30 mins, could possibly look after, just got back from my long wikimania flight though too [15:33:57] how long do I have? [15:34:01] addshore: T200269 (duplicate of T200072?) is blocking the train, we need somebody with context to review (and +2) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/447405 [15:34:01] T200269: Unable to undelete revision (Fatal error: given Title does not belong to page ID, RevisionStoreRecord) - https://phabricator.wikimedia.org/T200269 [15:34:02] T200072: MCR causes Cognate integration test fails: The given Title does not belong to page ID 2 but actually belongs to 4 - https://phabricator.wikimedia.org/T200072 [15:34:17] addshore: since the train is blocked for a week... no rush :D [15:34:53] but as soon as possible would be great, if we want to unblock last week's train and start with this week's :/ [15:34:53] zeljkof: ...not really [15:35:11] greg-g: sorry, bad joke :/ [15:35:18] addshore: please do so as soon as possible, we need wmf.13 unblocked before we can get moving on wmf.14 today [15:35:41] heh a Cognate integration test caught a core bug? perhaps Cognate should run for the gate of core? (if it isn't already) [15:35:47] * addshore will have a look in 25 mins [15:35:56] addshore: great, thanks! [16:10:26] addshore: Amir1 is merging and backporting [16:10:49] addshore: it was a pretty straightforward fix [16:23:22] anomie, Amir1, addshore: is T200072 resolved by 447405 (and backports to .13 and .14)? [16:23:22] T200072: MCR causes Cognate integration test fails: The given Title does not belong to page ID 2 but actually belongs to 4 - https://phabricator.wikimedia.org/T200072 [16:23:40] zeljkof: Should be. [16:24:18] I can test it on testwiki following the instructions from T200269 once you've backported. [16:24:19] T200269: Unable to undelete revision (Fatal error: given Title does not belong to page ID, RevisionStoreRecord) - https://phabricator.wikimedia.org/T200269 [16:25:30] zeljkof: On the backports now [16:25:39] the .13 is merged and I'm deploying atm [16:25:47] Amir1: cool, thanks [16:26:17] anomie: could you please test it when Amir1 deploy's .13 backport? [16:26:39] Just let me know when it's deployed. [16:26:48] sure [16:27:04] * addshore is still in my meeting [16:44:33] anomie: Amir1 has deployed .13 backport, please test and let me know if it fixes the problem [16:44:57] zeljkof: That already happened in #wikimedia-operations [16:44:59] anomie did test it in mwdebug1002 before moving forward :) [16:45:23] anomie, Amir1: ah, cool, missed it there : [16:45:26] :) [16:46:01] anomie: so, what I care about, is the train unblocked? [16:46:23] zeljkof: That bug is fixed. I don't know if you have others. [16:46:25] I'm waiting for a "yes" from you so I can deploy .13 everywhere [16:46:38] ok, great, that was the only blocker [20:03:40] heh i don't think we have quorum for techcom call this week. nobody's on the call but me so far :D i think everyone's traveling [20:07:16] never mind it's tuesday [20:07:17] what the hell [20:08:02] * brion returns brain to manufacturer for repair [21:20:57] brion: Happy Tuesday ;-) [21:21:02] :D [21:35:43] you're week just got longer! congrats/sorry! [21:40:09] heh