[08:24:02] greg-g tgr|away ack, I see the task got resolved eventually [09:22:59] godog: question is whether we still want/can make the request skip Varnish [09:45:41] tgr: I'm not sure either, in what cases is the job invoked? [09:59:41] godog: after every file upload, it generates the standard thumbnail sizes (used by the file page links and/or MediaViewer) [10:07:50] ack, I guess for small uploads it might result in a snappier experience the first time the uploader sees the page, assuming the job gets there before the browser [10:08:26] for mass uploads hitting varnish might just be pointless to put objects in cache [10:08:50] I'm +1 to keep it internal, namely using ms-fe.svc instead of upload.svc [16:29:21] legoktm: Did you see the code sniffer post merge fail? [16:29:21] 16:12:14 PHP Fatal error: Cannot declare class MediaWiki\Sniffs\AlternativeSyntax\UnicodeEscapeSniff, because the name is already in use in /src/MediaWiki/Sniffs/AlternativeSyntax/UnicodeEscapeSniff.php on line 26 [16:29:21] 16:12:14 PHP Stack trace: [16:31:39] (yes) [16:31:40] anomie: could you look at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/448029 ? trivial but needs to land before next train [16:33:30] +2'd [16:35:07] thx [16:35:43] Lego beat me to it. [17:20:33] phpcbf keeps timing out for me... [17:22:28] Reedy: what kind of timeout? is it the composer one? [17:22:37] [Symfony\Component\Process\Exception\ProcessTimedOutException] [17:22:37] The process "phpcbf" exceeded the timeout of 300 seconds. [17:22:47] just run it manually instead of through composer [17:22:50] ./vendor/bin/phpcbf [17:24:38] there's also https://getcomposer.org/doc/03-cli.md#composer-process-timeout [17:26:02] seems to be doing awhole load of nothing [17:27:11] you can pass -v I think? by default it doesn't output anything [17:30:24] Reedy: Want me to do it for you? [17:32:45] Ha. `Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 2097160 bytes) in /Users/jdforrester/Documents/code/vagrant/mediawiki/vendor/squizlabs/php_codesniffer/src/Tokenizers/PHP.php on line 1467` [17:33:37] lol [17:33:41] Done them all manually [17:35:07] I think just MediaWiki.NamingConventions.ValidGlobalName.allowedPrefix to deal with [17:35:39] that one should just need the exclusion in .phpcs.xml updated [17:35:48] or maybe some phpcs:disable statements [17:36:09] Yeah [17:36:10] There's 13 [17:36:32] Handful of maintenance files [17:44:45] https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/448066/ [17:44:47] Should be good now... [20:40:54] anomie you should be able to unmark wips now (if your a project owner of where the change ends up) [20:47:41] bpirkle_: https://office.wikimedia.org/w/index.php?title=MediaWiki_Platform_Team_Onboarding&type=revision&diff=235287&oldid=234308 [20:50:02] legoktm: thanks for the edit! [23:25:48] Krinkle: I don't want to wheel war with you on https://wikitech.wikimedia.org/wiki/MediaWiki:Sitenotice -- that switch is needed for https://wikitech-static.wikimedia.org/wiki/Main_Page [23:26:29] bd808: Hm.. good point. I was cleaning up empty non-empty sitenotices on a bunch of wikis, didn't look at the logic in particular [23:26:35] however, do you see the problem? [23:26:48] I now see [dismiss] on every page, despite there being nothing to dismiss. [23:26:57] oh... that's gross [23:27:01] hmmm [23:27:02] hiding it in this way isn't supported. [23:27:23] It used to work (pre 2013? 2015?) but was removed because of complexity in supporting it and other reasons I don't remember. [23:27:49] I guess we could add a placeholder message on the real wikitech advertising wikitech-static [23:28:11] there was a message in there until last weekend about the labs -> cloud rename stuff [23:28:54] Why not use $wgSitenotice for the wikitech-static sitenotice? [23:29:07] If it's only for wikitech-static, it might be acceptable to inject via Common.js conditionally [23:29:10] or that ^ [23:29:15] legoktm: because andrew and I never thought of that!? [23:29:35] https://www.mediawiki.org/wiki/Manual:Interface/Sitenotice [23:29:38] legoktm: I'll file a task :) [23:30:17] :) only caveat seems to be that an on-wiki sitenotice will override that [23:32:33] but then you could go back to the ifeq hack I guess [23:32:49] yup [23:38:21] T200479 [23:38:22] T200479: Set wikitech-static sitenotice via $wgSitenotice - https://phabricator.wikimedia.org/T200479 [23:40:51] Daniel: TimStarling: Wanted to make sure https://phabricator.wikimedia.org/T199416#4451623 is known - I can help with the implementation if short on time, but would like to know first what approach to take, not very familiar with the MCR area yet.