[14:13:44] <DanielK_WMDE_>	 anomie: can you have a look at this patch for getSlotsQueryInfo? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/454584
[14:14:03] <DanielK_WMDE_>	 Should be uncontroversial I think, but I'd like to know your take on this
[16:47:56] <tgr>	 DanielK_WMDE_: which one was the phase3 task you mentioned in the meeting? T194043 or T194038?
[16:47:56] <stashbot>	 T194038: Introduce ContentHandler::getSecondaryDataUpdates to replace Content::getSecondaryDataUpdates - https://phabricator.wikimedia.org/T194038
[16:47:57] <stashbot>	 T194043: Replace usages of Content::getSecondaryDataUpdates - https://phabricator.wikimedia.org/T194043
[16:49:23] <DanielK_WMDE_>	 tgr: T194043 is the goal, but you need T194038 first
[16:49:35] <DanielK_WMDE_>	 at least I think you do
[16:49:46] <DanielK_WMDE_>	 if you find a way around that, that's also fine
[17:37:39] <DanielK_WMDE_>	 tgr, anomie: this is also blocking the RevisionRenderer thing: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/453190/7
[17:52:50] <legoktm>	 I think someone in here could answer my question on https://phabricator.wikimedia.org/T202571: Does Language::convert() also do HTML escaping?
[17:55:15] <DanielK_WMDE_>	 tgr: i tried to review the DifferenceEngine fix, but my mind went blank. should probably go home
[17:55:35] <DanielK_WMDE_>	 i suppose anomie better understands what's going on there
[18:00:18] <tgr>	 DanielK_WMDE_: yeah
[18:01:38] <tgr>	 anyway, I think the only thing that's still broken in production is some Translate diffs so no tragedy if it stays like that over the weekend
[18:03:49] <DanielK_WMDE_>	 ok
[18:03:55] <DanielK_WMDE_>	 i'm wrpping up for today
[18:04:04] <DanielK_WMDE_>	 i'll see what I can do while I'm on the train tomorrow
[18:04:26] <DanielK_WMDE_>	 train rides are better for building stuff than for reviewing
[18:04:31] <DanielK_WMDE_>	 debugging might work :)
[20:13:04] <Hauskatze>	 does maintenance/updateCredits.php fail for you? I've got an exception
[20:13:24] <Hauskatze>	 Fatal error: Uncaught Error: Class 'Collator' not found in ...\maintenance\updateCredits.php:72
[20:19:28] <tgr>	 Hauskatze: sounds like a composer problem
[20:19:56] <Hauskatze>	 I'll run composer update
[20:20:19] <Hauskatze>	 I think I did some git clean latelly that might have removed some files
[20:26:09] <Hauskatze>	 still running
[20:28:29] <legoktm>	 https://secure.php.net/manual/en/class.collator.php
[20:28:40] <legoktm>	 you're missing the intl extension then
[20:31:16] <Hauskatze>	 still failing after composer update --no-dev
[20:31:24] <Hauskatze>	 looking at legoktm's link
[20:33:54] <Hauskatze>	 huh, for Windows it's not that easy
[20:34:01] <Hauskatze>	 giving up :D
[20:34:06] <Hauskatze>	 but thanks anyway
[20:45:58] <davidwbarratt>	 uhh, if I have a speical page (that uses OOUI) is there no way to group fields into different <fieldset> with <legend> ? I see you can do it with the whole form, but I'm not seeing a way to do it with a specific fields
[20:49:08] <davidwbarratt>	 or I guess it doesn't have to be those specific tags, but rather, a logical way to group fields
[20:53:28] <davidwbarratt>	 I see HTMLForm::displaySection() I think perhaps that's what I'm looking for
[21:44:13] <RoanKattouw>	 idk the details but you should definitely be able to group fields into multiple fieldsets per form
[22:05:36] <RoanKattouw>	 Could someone please review this patch for a train blocker? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/455013
[22:05:44] <RoanKattouw>	 (cc anomie legoktm )
[22:05:58] <legoktm>	 hi
[22:06:19] <legoktm>	 well I didn't do a very good job reviewing the first patch
[22:07:39] <legoktm>	 RoanKattouw: +2'd. I would say that if it still has problems after this we should be reverting the patch out of wmf.18
[22:07:46] <RoanKattouw>	 Agreed
[22:08:06] <RoanKattouw>	 I was going to recommend that but then I spotted the bug
[22:08:14] <RoanKattouw>	 Thanks legoktm 
[22:09:10] <legoktm>	 Also this API of setting a callback isn't that great either
[22:10:27] * thcipriani cherry-picks change
[22:11:34] <RoanKattouw>	 Honestly I think the check that I introduced probably should be outside the callback somehow, and prevent registration of the callback
[22:12:49] <RoanKattouw>	 But I couldn't wrap my head around what exactly the circumstances are in which the callback should and shouldn't be registered in a short amount of time, so I went with a minimal fix
[22:43:25] <Krinkle>	 addshore: Is #Wikidata-campsite the new #Wikidata for triage/kanban?
[22:45:51] <Reedy>	 Krinkle: It's the people doing UBN and maintenance and stuff while other people are sprinting etc
[22:46:26] <Krinkle>	 could use a project description. I guess the springis the iteration-Infinity?
[22:46:30] <Krinkle>	 sprinting*
[22:46:47] <Reedy>	 Has it not got one? I poked Lydia about that a while ago and she was gonna get Ras to fix it..
[22:47:08] * Reedy pokes again