[09:22:54] Krinkle: i just wrote a descripton on the board [09:23:47] if you tag #wikidata we will see it anyway, but that tag contains so much stuff, the campsite tag is the board things get sifted through before going into the kanban [09:24:12] and yes the iteration infinity is the actual work board for the team then [10:13:57] addshore: do you know who could review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/454799? [10:14:13] probaly me! [10:14:34] What is the mcrundo action? :D [10:15:11] uh, I should really have added a commit summary [10:15:28] :D [10:15:34] but yes, I should be able to review it today [10:18:06] addshore: edited [10:18:10] thanks! [10:23:33] tgr: is there a reason you only set $undoIsLatest if $current is instance of Revision? [10:24:30] I guess it is only needed for the "legacy" calls that use Revision? / don't pass the parameter themselves? [10:41:06] addshore: yeah. Also it's how the parent implementation does it. [11:23:18] hi! Trying my luck here, can we have mediawiki installer to run a script / maintenance script at installation? [11:23:55] I am looking at TrustedXFF extension which does not automatically populate cache/trusted-xff.cdb https://phabricator.wikimedia.org/T198120 [15:18:25] hashar: the schema update hook, maybe? [15:20:37] tgr: hello. So just like a database update? :\ [15:26:01] hashar: well it is a database update, of sorts [15:26:27] but yeah, not very clean, but it's the only thing I can think of off-hand [15:26:41] not that I'm an expert on the installer [15:27:18] yeah ... I will try to find an extension that has that use case and happilly copy paste [15:27:21] thank you tgr! [15:27:36] anomie: I tried google and github search and found nothing overriding getUndoContent other than WikiBase, I'm OK with breaking B/C on this one [15:29:05] tgr: do you know about kunal code search ? https://codesearch.wmflabs.org/search/?q=getUndoContent :D [15:29:24] Echo FlaggedRevs and Flow match [15:30:08] they don't override, they just call the method [15:30:32] Flow doesn't even call it, it just has the same name [15:32:14] tgr: Either way we're breaking BC. Part of the question is if we make it obvious (as it is now, the signature will mismatch) or subtle (unexpectedly falling back to the base-class implementation). [15:34:01] the new method could construct mutable revisions and call the old method [15:34:14] not worth the effort though [15:34:46] also would probably behave unexpectedly with the ID check [15:36:07] anomie: do you have time to look at the css-sanitizer patch today? The WLM people would like to set up their landing pages some time next week [15:39:37] tgr: Sure. I see you updated it, I'll re-review it now. [16:13:41] tgr: Reviewed. A few minor issues. [16:28:23] McRundo, some Celtic personification of a MediaWiki component? [17:53:51] tgr: Reviewed again. One line is missing unit test coverage, otherwise it looks good. [18:16:42] tgr: Merged it, and tagged v2.0.0. [18:54:34] thanks! [20:33:33] tgr: I found out how to run a maintenance script in update.php DatabaseUpdater::addPostDatabaseUpdateMaintenance() :] [20:49:03] Hm.. where do we enable phan rules? [20:49:04] https://phabricator.wikimedia.org/T114846 [20:49:23] I found a blacklist in mediawiki/core phan/config and an empty whitelist that says it is only used if it is non-empty [21:26:49] anomie: Did you want someone else to merge https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/455221 ? [22:49:04] Krinkle: tests/phan/config.php is where they're disabled [23:09:31] Aye, so where are they enabled? [23:13:17] Krinkle: hm, the default phan ruleset I guess? we're also running a pretty old version of phan still :/ [23:13:43] Ah, right. so presumably it has all useful rules on by default [23:13:54] does that mean it is already enabled for us? [23:14:59] That specific rule I'm not sure, best way is to just test it? [23:15:17] Upgrading phan is on my to-do list after we get the phan-taint-check plugin everywhere :)