[08:56:23] anyone around for two quick JS editing reviews? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/455481 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/449626 [08:56:34] Reedy maybe? [08:57:20] the second is not really urgent, the first would be nice to get in before the EU SWAT [11:46:10] DanielK_WMDE_: would you have time to review https://gerrit.wikimedia.org/r/c/mediawiki/core/+/455401 today? [12:52:33] James_F: No, I just forgot about it after the discussion on the TemplateStyles patch cleared up. [13:49:05] Deskana: do we need TemplareStyles skin support in production today or is it enough if it is on the train this week? [14:38:53] tgr: I think the train would be fine provided we tell them on the task. [14:39:09] ack, will do that [17:21:48] tgr: +2'd both [17:21:59] thx! [19:50:25] legoktm: tgr: i commented on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/449626 [19:50:56] mmm [19:51:31] MatmaRex: thanks [20:36:39] tgr|away: In https://phabricator.wikimedia.org/T190015#4534698 you said you'd mark it as done, but… you didn't. Did you forget or is there more to do? [22:59:08] anomie: could you re-review the terminology used in https://gerrit.wikimedia.org/r/449149 ? I think I renamed it all properly [23:02:57] legoktm: I'm looking to build on the implementation of patch-coverage for something that extracts and compared performance measurements instead (navtiming, mw.loader.profiler etc.) [23:03:07] Do I understand correctly that it only installs MW once? [23:03:20] Yes [23:03:51] The workflow is: setup MW, read/analyze git diff, run tests, checkout HEAD~1, run tests again, print diff of results [23:09:54] James_F: oops, thanks, I forgot [23:34:58] legoktm: cool, so it's pretty quick but with the trade off that with schema changes it might not work. [23:35:30] how does the checkout part know where the repo in question is, given it does both core and extensions, right? [23:50:18] DanielK_WMDE_: 50% of the time, you spell table as "tabel" [23:51:49] foreach ( $tablesCloned as $tabelName ) { [23:56:11] there's also one in a comment in NameTableStore [23:59:06] apparently it would be correct in Dutch and acceptable in Middle English :) [23:59:47] but you know modern english represents the final triumph of analogy over common sense