[11:25:19] addshore: just wanted to mention https://gerrit.wikimedia.org/r/c/mediawiki/core/+/457420 in case you are busy doing the same thing [11:26:00] I started on it right after my gerrit comment about MediaWikiPHPUnitTestListener [11:27:13] I realised c804a0b was a bad idea pretty soon after it was merged, but DanielK_WMDE had already hit +2 [11:27:31] after it was submitted I mean [11:30:31] Currently having a travel nightmare, but will look later today! [14:11:02] tgr: hey :) [16:37:57] tgr: do you think you could review/approve this? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/456542 [16:38:15] it'S an amendment i made on one of tim's patches, and he pulled it out, so now neither of us can +2 it :) [16:39:01] looking [17:00:23] tgr: thanks. hm... does zuul pick this up now, or does it need another kick of some sort? [17:01:32] in theory it should, but apparently that didn't happen [17:02:56] maybe it's dead? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/456541 should have merged already [17:04:39] I'm getting temporary CI outages when fetching composer/npm packages [17:04:50] maybe there are too many queued [17:07:29] maybe zuul is on holiday [17:09:12] 16:53:09 error: copy-fd: write returned No space left on device [17:09:17] https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/1852/console [17:09:21] *sigh* [17:10:35] at least that means more than "404 not found npm" [17:13:12] cf. T182266 [17:13:12] T182266: Error "TransportException 404 Not Found" in Jenkins jobs using composer - https://phabricator.wikimedia.org/T182266 [17:17:57] tgr et al. T203325 is a regression and is kinda annoying, but I cannot find where it comes from [17:17:57] T203325: BotPasswords right selection form shows plain-text html - https://phabricator.wikimedia.org/T203325 [17:18:05] the page is broken [17:24:00] Hauskatze: apparently CheckMatrix 'column' field keys are raw in HtmlForm but escaped in OOUI [17:25:08] if it were an extension we could add something to extension.json so they appeared in raw html iirc (??) but this is core, so I'm not sure [17:27:31] you would add it to $wgRawHtmlMessages in that case [17:27:51] but anyway, it's not a raw message anymore, that is what's causing the problem [17:28:21] just replace ->escaped() with ->text() or something [17:52:46] tgr: did you reply to my comments on your patch? I see you addressed some of them [17:53:44] oops [17:53:51] the one about the cache timestamp of a null edit probably needs fixing... i think i broke this when i make null edits set $this->revision [18:09:12] tgr: how do we move on with the view patch? do you think you can give a +2 on that, or do you want brad to have another looks? [18:09:22] we should probably give a heads up when this goes live, btw [19:39:37] DanielK_WMDE: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/452708/14/includes/page/Article.php#747 still seem unaddressed [19:40:01] and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/452708/13/includes/diff/DifferenceEngine.php#840 [20:33:20] tgr: good morning :] From friday, I could use a review for ReadingLists https://gerrit.wikimedia.org/r/447086 :D It is not the idea fix but it works :]