[13:59:47] <DanielK_WMDE_>	 anomie: to you think the Article overhaul and its parent can go in today? I think we sorted out the remaining details yesterday.
[13:59:58] <DanielK_WMDE_>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/452708/24
[14:54:00] <bawolff>	 legoktm: CindyCicaleseWMF : https://phabricator.wikimedia.org/T203095
[14:55:10] <CindyCicaleseWMF>	 I saw - THANK YOU! I really appreciate your work on this with the very tight deadline and much concurrent effort! I will follow up on your requests with Legal.
[14:55:49] <CindyCicaleseWMF>	 bawolff: ^
[15:03:46] <paladox>	 CindyCicaleseWMF i wonder if a "step by step on how to contact your eu representative" should be added. Since im sure many users won't know how to contact there's like me.
[15:06:00] <CindyCicaleseWMF>	 paladox: the site will walk the user through emailing, tweeting to, and phoning their  member of the EU parliament.
[15:06:15] <paladox>	 ah ok thanks :)
[15:12:26] <addshore>	 Reedy: " I wonder if we can make CI more smart about merging vendor patches" yes please
[15:12:55] <addshore>	 we should improve mediawiki-vendor in general
[15:12:56] <addshore>	 https://phabricator.wikimedia.org/T179663
[15:13:19] * addshore goes back to frying fish
[15:33:31] <legoktm>	 addshore: Jan had a nice RfC for this :/
[15:33:45] <addshore>	 JanZ?
[15:34:39] <addshore>	 it's only a matter of time until it violently explodes in someones face, probably will show up on group0 though....
[15:36:11] <legoktm>	 Yep!
[15:37:01] <legoktm>	 https://www.mediawiki.org/wiki/Requests_for_comment/Streamlining_Composer_usage bit outdated now
[15:38:13] <legoktm>	 I really appreciated how that has all the threats explicity listed 
[17:15:46] <James_F>	 DanielK_WMDE_: https://phabricator.wikimedia.org/T203583 :-(
[17:20:14] <DanielK_WMDE_>	 James_F: looking. I have about 40 minutes before i have to head out, to make it home in time for techcom.
[17:20:49] <James_F>	 DanielK_WMDE_: It may be that the answer is "tough, that was always unreliable and now it won't ever work, sorry".
[17:21:28] <DanielK_WMDE_>	 James_F: i put a lot of time and thought into making this work, so it really should :)
[17:21:36] <DanielK_WMDE_>	 also, anomie will kill me if it doesn't
[17:21:45] <James_F>	 Ha.
[17:31:17] <anomie>	 DanielK_WMDE_: It looks like during the pre-save transform your changes to Parser::getRevisionObject() are making it use the saved revision where previously it returned null because $this->mRevisionId was unset.
[17:32:39] <anomie>	 I guess your current revision callback isn't set up yet when PST is happening.
[17:34:38] <DanielK_WMDE_>	 anomie: that's probably it. writing a test to reproduce the issue now.
[17:53:28] <DanielK_WMDE_>	 anomie: the current revision callback was actually never set up on the ParserOptions used for PST.
[18:03:21] <James_F>	 DanielK_WMDE_: Timecheck that you have to leave to make the meeting.
[18:05:21] <DanielK_WMDE_>	 James_F: thank you James :)
[18:05:32] <DanielK_WMDE_>	 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/458251