[01:20:24] <legoktm>	 James_F: Reedy: findDeprecated.php in core
[01:21:38] <James_F>	 Oh, I thought that was just reporting wfdeptecated calls?
[01:22:06] <James_F>	 Which is what I have grep for.
[01:25:39] <legoktm>	 if it starts with - it means its soft deprecated and + means hard deprecated
[01:25:54] <legoktm>	 (or vice versa, I'm trying to recall from memory)
[03:52:57] <Krinkle>	 James_F: hm.. VE doesn't seem to be loaded on wikitech (still/again). Can't find an open issue about it. Do you know of one?
[03:53:01] <Krinkle>	 http 500 doc error
[03:58:31] <Krinkle>	 Found it, although closed - https://phabricator.wikimedia.org/T163438
[08:17:22] <legoktm>	 bpirkle: https://phabricator.wikimedia.org/T204884#4633082 whee
[14:45:49] <bpirkle>	 legoktm: so it begins!
[17:09:20] <James_F>	 Krinkle: Hmm. Sounds like the new config for wikitech that was rolled out by SRE yesterday doesn't work?
[17:12:06] <Krinkle>	 Yeah
[18:03:03] <legoktm>	 James_F: haha ok the issue is really dumb
[18:03:04] <legoktm>	 			wfDebug( __METHOD__ . ": trying to get npt time on NaN:" + $time );
[18:03:12] <legoktm>	 + isn't the string concatentation operator
[18:03:41] <legoktm>	 so it's complaining (rightly) that you're trying to add two strings which obvs aren't numeric
[18:03:48] <James_F>	 Gnargh.
[18:04:00] <James_F>	 I
[18:04:06] <James_F>	 I'll fix after this meeting.
[18:05:55] <Krenair>	 reminds me of that time . vs. + was mangling URLs used by MW to contact one of the services (?)
[18:06:07] <Krenair>	 think that was the one that ops supplied a patch for and I deployed :)
[18:06:15] <subbu>	 that is probably a common "bug" ... when switching between JS and PHP.
[18:06:55] <Krenair>	 yes
[18:07:06] <Krenair>	 when switching from probably most other languages to PHP
[18:23:28] <James_F>	 We really should find a way for wfDebugs to be lazy-inited so their params aren't constructed and linters ignore them. ;-)
[18:25:29] <James_F>	 legoktm: oojs-router still appears broken on https://doc.wikimedia.org/cover/ ?
[18:25:51] <legoktm>	 James_F: varnish cache, it should expire in an hour
[18:26:12] <legoktm>	 I bypassed the cache earlier to verify it was fixed
[18:26:25] <James_F>	 Ha, OK.
[19:13:56] <James_F>	 legoktm: Can I steal 20 seconds of your time for a glance at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/461975 before I merge it?
[22:38:44] <legoktm>	 James_F: I can look when I get home