[02:18:25] trying to reproduce the extension test failure in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/450433 for simetrical [02:19:21] so I set up a new wiki which has that exact set of extensions [02:24:23] I set $wgWikimediaJenkinsCI=true, that is the simplest way to get Wikibase working, it is quite an impressive hack [02:26:15] and then there is composer-merge-plugin, nothing tells you when you need to add an extension's composer.json, you're meant to just work it out from the class not found error [02:29:24] TimStarling: the last part, for quibble/wmf-related jobs can be avoided with mediawiki-vendor presumably. [02:30:03] quibble can also be used locally, which was part of its reason to be created, https://github.com/wikimedia/integration-quibble [02:30:32] it's not trivial to get going, but in theory nothing in Jenkins makes it different, and everything else is moved to quibble. [02:30:34] yeah legoktm tried to make me install it once before [02:31:24] ^.^ [02:31:34] the main hurdle for me is that it clones MW freshly, instead of being able to )(easily) pass an existing install, which is made worse by it writing LocalSettings and installing all extensions found locally. [02:31:52] (when passed) [02:31:55] using mediawiki-vendor might work for this one thing, but it's not very flexible, I'd have to revert it after I'm done with this job [02:32:37] There might be a way to skip the install step, at which point, you'd manually include the extensions you want first on the local wiki. but then there's the difference from configuration, such as wgWikimediaJeninsCI=true. [02:32:53] Krinkle: if you use --skip-zuul it doesn't clone or checkout stuff [02:33:16] Really though, the Jenkins job shouldn't have to add local settings. That's part of what makes it more complicated than it should/could be. [02:33:28] legoktm: Yeah, but then it still runs the installer. [02:33:33] Which has benefits, but also downsides. [02:33:47] yeah [02:33:50] The real issue is with the extensions/tests, imho, not the way of running them. [02:34:22] As exemplified by our tests failing on Travis currently due to a test relying on wgSitename. [02:34:47] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/451638 [02:35:35] if I ran it under quibble, how would I, say, add a wfDebug() to a line of code and re-run a single test? [02:37:00] reproducing alone is not really the point, I can see on jenkins that it's broken, the problem is that I have to take it apart and put it back together again to find out where it's broken [02:37:53] Yeah. The easiest way to accomplish that is by having the dev environment not be different from the environment in which you reproduce the issue. So that it is "just" installing the extensions and running the test in question. [02:41:43] I'm quite frequently hitting the 60s fatal timeout on seemingly normal web requests on mwdebug2001. Earlier last week as well. Seems to get better after a while, but it seems like whenever I first try something the first one or two requests are really slow. Simple things like action=raw and action=history on a page with a few revisions. [02:58:51] In Filesystem.php line 207: Could not delete extensions/UniversalLanguageSelector//i18n/ro.json: [02:59:32] I'm glad I don't let composer write to my main source tree [03:00:04] there was a test error from Translate so I added it to my composer.local.json, and it tried to install ULS from composer over a gerrit checkout [12:37:56] 13:30:18 [] The property VisualEditorAvailableContentModels is not defined and the definition does not allow additional properties [12:38:30] I'm guessing that's related to a missing CI dependancy in ProofreadPage to make it work? [16:55:18] Reedy: Sounds like. [16:56:48] Reedy: Except PRP depends on VE in zuul/parameter_functions.py already (and LabeledSectionTransclusion). [16:57:00] Lego pointed out it's a change of attributes [16:57:14] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ProofreadPage/+/465412/4/extension.json [16:58:47] 16:03:40 >> Error: Unable to parse "extension.json" file (Unexpected string in JSON at position 9143). [16:58:50] Useful error is useful [19:02:49] > Krinkle: Really though, the Jenkins job shouldn't have to add local settings. That's part of what makes it more complicated than it should/could be. [19:02:52] ^^ I agree [19:03:05] if I could just mount my mediawiki dir and local settings into quibble it would be great [22:12:20] 22:46:39 8) Flow\Tests\Api\ApiFlowModeratePostTest::testModeratePost [22:12:20] 22:46:39 MWException: Expected array, Iterator or IteratorAggregate but received:MediaWiki\Notifications\EchoCallbackIterator [22:12:27] Why has it decided it's not an instanceof [22:21:27] > var_dump( get_class( $a ) ); [22:21:28] /var/www/wiki/mediawiki/core/maintenance/eval.php(78) : eval()'d code:1: [22:21:28] string(44) "MediaWiki\Notifications\EchoCallbackIterator" [22:21:28] > var_dump( $a instanceof Iterator ); [22:21:28] /var/www/wiki/mediawiki/core/maintenance/eval.php(78) : eval()'d code:1: [22:21:28] bool(true) [22:28:35] instanceof doesn't like use statements apparently [22:46:44] James_F: uh, sorry. I thought we already merged that. [22:47:24] tgr: No worries. :-) I'm now dealing with the next level of problems (and trying to work out if I've caused them). [23:46:42] Reedy: I hope this will not be merged without s/Echo// ?