[15:51:07] anyone have a second to review this https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Dashiki/+/464469/ which follows up on my bad self-merge here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Dashiki/+/463309/ ? [16:11:32] milimetric, you self-merged on a deployed extension? [16:20:06] Krenair: yes, I didn't know... I waited around for a while and it seemed like such a tiny change [16:20:48] but it never got deployed if that helps [16:21:08] (I'm actually not sure why, I thought all merged changes were deployed automatically on Tuesdays) [16:21:30] it got included in wmf/1.32.0-wmf.26 [16:21:38] which is on some wikis already [16:23:20] remaining wikipedias tomorrow theoretically [16:24:02] I do wonder if a change that touches an en.json file can really be 'tiny' [16:27:01] I mean I admit I don't understand all the ways things can blow up, but as long as the json is valid, are there ways to blow up the site by changing **.json files? (also, btw, this extension is only enabled on meta, nowhere else) [16:29:09] no but touching en.json means translators now have stuff to do [16:29:43] worth getting right the first time round [16:40:27] oh, I see, yeah, that part's not going to change for sure, the issues with the code are mostly that it's using JsonConfig and can't use some standard methods from Title to do some of the string comparing / evaluating [16:53:32] James_F: I couldn't find an example of what you're saying here https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Dashiki/+/464469/1/i18n/en.json, I looked at https://www.mediawiki.org/wiki/Manual:Messages_API and at other extension messages like https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/i18n/ve-mw/en.json [16:54:02] you mean instead of something: '(like this)', I could do something_parens: '($1)' and something: 'like this'? [16:54:29] seems a little overkill, but I'm happy to do it the standard way [17:00:54] hello. If there is any magician familiar with the Mediawiki updater and updatelog table, I could use a review of a patch for REL1_27 https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/467895/ [17:01:12] it is to prevent a time based race condition when one runs install.php && update.php [17:01:54] update.php would log an entry with a key that uses 1 second resolution, and that could clash with the entry added by install.php ;] [17:04:12] Reedy: I got a patch for the updater duplicate entry :] ^ [17:23:27] TimStarling, "I’m not the person to call if you need someone to design something to stand on when you’re painting" ... that is hilarious .. did someone actually call you for that? (link trail: spark project showcase -> old spark project -> your blog post -> https://tstarling.com/blog/about-me/ :-) [18:09:45] milimetric: The global message is named 'parentheses', not 'parens'. [18:32:34] hashar: Any idea why we don't seem to suffer this on newer branches? [18:42:20] thanks anomie! fixed that, and now I get where those are coming from so I'll look for them in the future [18:50:39] Reedy: yes. On newer branch the code got removed/refactored entirely :] [18:50:58] Fair [18:51:00] Reedy: so it is merely just for 1.27 :] [18:57:36] Reedy: thanks :] [19:55:48] subbu: nice to know someone appreciates my jokes [20:15:00] :) [20:21:30] TimStarling: for what its worth I love your jokes...when I get them. :) [21:35:01] In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiEditor/+/467885 , I'm using a function from WikimediaEvents, conditional on WikimediaEvents being loaded, but phan throws an error. How can I make phan let me do this? [21:35:33] The code looks like $foo = $extensionRegistry->isLoaded( 'WikimediaEvents' ) && WikimediaEvents::foobar(); , so it's a soft dependency on WME that fails gracefully if WME is not installed [21:38:56] RoanKattouw: easy [21:38:58] RoanKattouw: a) I don't think it's right for WikiEditor to have code that even optionally depends upon WikimediaEvents, but b) https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/TwoColConflict/+/master/tests/phan/config.php#5 and add the dependency in CI's list [21:39:07] yeah, that [21:41:42] Re A, I mostly agree, but that ship sailed a while ago and there are only bad options. Re B, thanks! How do I "add the dependency in CI's list"? Is that in the integration/config repo? [21:43:40] https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/zuul/parameter_functions.py#136 [21:46:35] Thanks! https://gerrit.wikimedia.org/r/#/c/integration/config/+/468171