[13:46:10] legoktm: You merged https://gerrit.wikimedia.org/r/c/mediawiki/core/+/468476 (for 1.32), but https://gerrit.wikimedia.org/r/c/mediawiki/core/+/468475 (same patch for master) is still unmerged. I could use the latter since it's blocking me moving forward with comment table stuff. [14:43:34] anomie: oops, I totally missed that. I didn't expect people to create backports before they were merged in master [14:43:39] +2'd now [14:44:50] thanks [15:27:26] RoanKattouw: hey, around? [16:00:40] Yeah, what's up? [16:54:08] RoanKattouw: Can you take a look at this? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/468980 [16:54:21] I need to backport it for morning SWAT [17:09:04] Looking [17:10:33] Thanks [17:10:45] RoanKattouw: Specially the comment in the ticket might help [17:11:02] RoanKattouw: Oh, thanks for the +2 \o/ [17:11:04] +2ed [18:34:34] anomie: re https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/468996 is our goal to be bug-for-bug compatible with Lua 5.1? or should we be trying to fix things that are undocumented like this? [18:35:41] legoktm: In general, for ustring I try to keep things bug-for-bug compatible with lua's string library. [18:36:12] Although if something is too hard I'm willing to just document the difference. [18:38:04] * legoktm nods [20:26:16] Any advice on a convenient way to create a page with thousands of revisions on my local mediawiki vagrant? [20:31:12] bpirkle: Special:Export to a file and Special:Import? [20:32:15] James_F: thank you, will give it a go [20:32:56] bpirkle: Barack Obama's article on enwiki is a traditional go-to for stress-testing. [21:27:52] The good news is, pages with many revisions delete quickly on my local. The bad news is, I was hoping they would be slow, so I could diagnose T207530 [21:27:53] T207530: Deleting pages on the English Wikipedia is very slow - https://phabricator.wikimedia.org/T207530 [21:28:44] My next thought was to try it on test.wikipedia.org, but I don't appear to have permissions to delete pages there. Is that available and/or is there somewhere better that might be fairly representative of prod architecture that I should try it? [21:32:24] bpirkle: what's your username on test.wp? I can give you permission [21:32:37] BPirkle (WMF) [21:33:10] (change visibility) 21:33, 22 October 2018 Legoktm (talk | contribs | block) changed group membership for BPirkle (WMF) from (none) to administrator (for testing) [21:33:30] confirmed, thank you! [21:50:03] bpirkle: confirmed as in you were able to reproduce this issue? [22:50:49] Permission change confirmed, issue not reproduced. [22:50:50] My test page still deleted quickly. It had very few revisions, but that really shouldn't matter. I'll poke at it a bit more after supper, but likely I'll need to get more info about whether this is happening on live for all pages, or only certain ones. I shouldn't be creating and deleting testing pages on live (even if I had delete permissions there). right? [22:55:52] bpirkle: as long as it's a page in your user namespace (e.g. https://en.wikipedia.org/wiki/User:BPirkle_(WMF)/sandbox, or any other subpage), it should be fine [22:58:42] (also, i just happened upon your user page, and that's a pretty neat setup) [23:01:44] MatmaRex: cool, I'll try it there. And thank you, still fine tuning my local setup, but it is working out pretty well so far