[21:10:45] <paladox>	 anomie hi, i doin't think the actor change works with https://github.com/wikimedia/mediawiki/blob/master/maintenance/rebuildtextindex.php
[21:10:52] <paladox>	 It generates this sql query:
[21:11:30] <paladox>	 https://phabricator.wikimedia.org/P7824
[21:11:51] <paladox>	 Which then can cause either the db to go all crazy or causes the mediawiki host to loose all it's ram.
[21:13:02] <paladox>	 it has "NULL AS" which im guessing could be the problem?
[21:15:14] <tgr>	 looks like the joins get omitted
[21:17:10] <paladox>	 i filled https://phabricator.wikimedia.org/T209885
[21:17:17] <paladox>	 oh
[21:17:34] <tgr>	 you probably need to change __METHOD__ to __METHOD__, [], $revQuery['joins']
[21:18:02] <paladox>	 ah
[21:18:04] * paladox trys
[21:18:05] <tgr>	 we really should have a helper method for converting a query info array to a query, it's a but fragile to let people do it by hand
[21:18:42] <tgr>	 or a Query object or something
[21:18:59] <paladox>	 tgr that works!
[21:19:00] <paladox>	 thank you!
[21:19:20] <paladox>	 tgr if we added it to the script would it break sites that doin't use actor yet?
[21:25:38] <legoktm>	 tgr: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/459242 :)
[21:28:10] <anomie>	 paladox: You should submit the patch for T209885.
[21:28:11] <stashbot>	 T209885: rebuildtextindex.php does not work with "actor" - https://phabricator.wikimedia.org/T209885
[21:28:22] <paladox>	 anomie ah ok :)
[21:28:25] <paladox>	 will credit tgr
[21:31:09] <paladox>	 anomie https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/474794/
[21:57:54] <paladox>	 anomie another issue or bug i've noticed is that when a extension calls User::newSystemUser it seems to create the user with id 0 thus breaking because you get errors like:Error: 1062 Duplicate entry '0' for key 'actor_user'
[21:58:00] <paladox>	 i have the full traceback
[21:58:36] <paladox>	 anomie https://phabricator.wikimedia.org/P7825
[22:04:51] <anomie>	 paladox: Can't reproduce. Why in your trace is it trying to create a user named '0', and how did $dbw->insertId() manage to return 0?
[22:05:39] <paladox>	 oh could it be because im migrating a site from 1.30 to 1.31 whilst doing the mgiration to actor all in one thing)?
[22:07:53] <anomie>	 It's possible some bug fix wasn't backported to 1.31.
[22:08:43] <paladox>	 hmm
[22:09:51] <paladox>	 [86bfa33caf84c3f2581f2b8e] [no req]   InvalidArgumentException from line 686 of /srv/mediawiki/w/includes/user/User.php: Cannot create a user with no name, no ID, and no actor ID
[22:10:05] <paladox>	 when i switch actor of for that wiki i get ^^ when running update.php
[22:58:36] <paladox>	 anomie wondering could you merge https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/474797/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/474796/ please?
[22:58:43] <paladox>	 they both have unrelated test failures.
[23:05:13] <tgr>	 legoktm: I can't make sense of https://integration.wikimedia.org/ci/job/mwext-php70-phan-seccheck-docker/26589/console
[23:05:45] <tgr>	 is that complaining about double escaping? it's not happening as far as I can see
[23:19:02] <paladox>	 anomie on another wiki, i get the duplicate id when doing just "User::newSystemUser( 'Delete page script', [ 'steal' => true ] );"
[23:26:30] <paladox>	 it works when going back to disabling actor (create the system user) then switch back to actor