[00:03:21] Amir1: Sorry, I had those on my todo list but had higher prio stuff to do (+Thanksgiving break) [00:03:23] Looking now [00:28:22] RoanKattouw: Thanks! [17:52:18] Ugh. T209582#4778505. [17:52:19] T209582: Unable to serialize r:46: Id 46 out of range. - https://phabricator.wikimedia.org/T209582 [18:36:19] wow [18:37:32] and since it was only fixed in PHP 5.4, we never encountered it in the 5.3 -> HHVM migration [19:10:13] James_F: I'm not sure what I'm missing, but eslint isn't working as expected in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DismissableSiteNotice/+/475841 [19:10:30] Yeah, looking now. [19:11:22] legoktm: Looks fine to me. `grunt-eslint` doesn't have any output in a non-failed state. Will check locally. [19:12:24] James_F: when I run it locally I'm getting https://paste.fedoraproject.org/paste/V8~sxexOVR77V6RoJuqGQw [19:12:47] ohhhh, this is https://phabricator.wikimedia.org/T206485 [19:13:14] It is, yes. [19:14:04] However there are other fixes I could complain about on the task (should extend wikimedia/client, etc.). [19:15:01] oh, please [19:17:12] Done. [19:18:52] James_F: so should https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Linting be updated to use the extends instead of "env"? [19:19:27] legoktm: Yeah, we're just transitioning to 0.9.0 now and that needs me to update that. [19:19:53] ok [19:27:16] <_joe_> oh my I just read https://phabricator.wikimedia.org/T210528 [19:27:31] <_joe_> it was most probably caused by me doing some benchmarking today [19:27:53] <_joe_> I'll take a look at the php patch tomorrow, and see if it can be applied to HHVM [19:28:36] legoktm: https://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions/JavaScript&diff=2986436&oldid=2954281 [19:29:13] <_joe_> legoktm: looks like the patch is huge, so I'd go with separating the cache keys for serialized objects maybe? [19:29:23] James_F: <3 [19:29:51] _joe_: yeah, that seems reasonable. I think anomie is right with "retrofitting that onto everything that currently uses serialize() would be quite a bit of work." [19:30:05] especially for upstream/library code [22:23:21] James_F: does eslint have an automatic fixer? I'm wondering if T210552 is something that's scriptable [22:23:22] T210552: JS Linting: Drop `dot-notation` keyword over-ride from all repos; no longer needed - https://phabricator.wikimedia.org/T210552 [22:24:08] legoktm: Yes. `./node_modules/eslint/bin/eslint.js --fix .`. [22:24:32] legoktm: And yes, dropping `dot-notation` could be done by that. [22:24:48] But upgrading to 0.9.0 is the main thing right now, and that's a fair bit more manual (new profiles). [22:25:38] is that something GCI students can do? [22:25:49] Eh. Maaaaybe. Most situations are bespoke. [22:25:58] Compare https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/459571 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/474961 :-( [22:27:24] Especially the new rules to spot and stop us using jQuery methods like $.each. [22:28:28] that looks reasonably straightforward except that some uses of $.each were replaced and others are just being disabled [22:29:29] Yeah, it's the knowing-what-to-do-when that's hard to give guidance on ahead of things. [22:29:47] I'd worry about a GCI student putting in a lot of work where I'd just say "nah, skip it for now, that's fine". :-( [22:32:46] good point