[17:05:06] anomie, legoktm: regarding https://phabricator.wikimedia.org/T210953 .. are all the extensions that matter to us searchable in codesearch.wmflabs ? [17:05:16] we wanna make sure we cover all that's needed [17:05:50] dmaza: As far as I know they are. legoktm would know better. [17:06:24] excellent. Thank you [17:10:00] Tchanders: test [18:08:55] anomie hi, im wondering how do we add "actor" support to https://github.com/wikimedia/mediawiki-extensions-ContributionScores/blob/master/ContributionScores_body.php#L63 please? [18:36:47] paladox: Step 1 would be to start using $dbr->select(), $dbr->selectSQLText(), $dbr->unionQueries(), and (if you care about Sqlite or MSSQL) taking into account if $dbr->unionSupportsOrderAndLimit() returns false. Then using ActorMigration would be much more straightforward, you should be able to follow the example of many existing uses. [18:42:54] thanks [18:45:26] AaronSchulz: are you around? Have some questions about ChronologyProtector [18:49:26] anomie: thanks for the reviews :) I'm going to have to find a plugin for atom to show me invisible characters... [18:52:00] legoktm: No problem. BTW, since there's no train this week I think we should backport these once they're merged. [18:52:46] oh, I didn't realize that [18:52:49] yes, definitely [19:00:42] SMalyshev: I'm waiting to board a flight [19:02:00] AaronSchulz: when has flying ever stopped anyone I mean Reedy from doing MW stuff? ;-) [19:02:18] I don't always deploy code, but when I do, I do it from a plane [19:03:38] Wolfman Reedy ;) [19:03:41] AaronSchulz: aha... if you happen to have a second, woudl like your help in https://phabricator.wikimedia.org/T210901 - basically, we have Kafka event going out, and outside process trying to get data related to that event and getting stale data from replica. And I would like to see if it's possible - e.g. with ChronologyProtector - to ensure I get fresh data [19:12:53] Reedy deploying code: https://commons.wikimedia.org/wiki/File:B-2_Spirit_bombing,_1994.jpg [19:13:44] Hauskatze: That's disturbingly accurate. :-) [19:14:28] deploying code from a plane [19:14:59] * Hauskatze making roasted chesnuts [19:15:08] *chestnuts [19:48:18] Well, here I am. [19:54:34] Hello, evanpro. :-) [19:54:47] \o [19:58:59] an evanpro ! [19:59:40] greg-g: it is very effective [20:27:27] evanpro: welcome :D [20:27:36] Thank you! [20:28:07] * evanpro is running through my onboarding checklist, joining all the things [20:52:40] anomie: ok, new patchsets uploaded [20:54:36] * anomie waits for Jenkins [21:00:32] <_joe_> Krinkle: should we install php-tideways, and configure it in wmf-config/profile.php for php7? [21:07:46] _joe_: TBD - https://phabricator.wikimedia.org/T206152 [21:10:03] <_joe_> Krinkle: php-tideways is conveniently packaged in debian [21:10:08] <_joe_> that's why I was asking :P [21:11:23] <_joe_> I'll comment on the task [21:11:38] Yeah tideways is appealing [21:11:55] But haven't tested or reviewed it in any way [21:12:24] <_joe_> we could install it on the mwdebug* servers first, and make some tests there [21:12:42] <_joe_> I am installing excimer there too this week, probably [21:14:32] <_joe_> I'm interested in looking at flamegraphs for some requests where php7 underperforms compared to hhvm [21:40:29] legoktm: All three patches are merged. [22:01:45] _joe_: we don't currently have flame graphs per request or per server, so that might be difficult. But once we have something like tideways we can make a text profile and call graph comparison via xhgui at least [22:02:09] <_joe_> right [22:02:36] <_joe_> yeah flamegraphs are just from sampling, but it's just a way of visualizing the same kind of data afterall [22:03:10] <_joe_> either one should show if php7 spends a lot of time in some particular part of the code compared to hhvm [22:03:37] Yeah. In many ways a call graph is better than a flame graph [22:04:45] Because it tells you in total how much time was spent in a function and how often a function was used. Regardless of whether those calls came from an identical stack [22:05:22] That is also the reason we can't build a tree or flame graph from the xhprof data. [22:06:56] More details about that at https://github.com/perftools/xhgui/pull/246 (TLDR: someone tried to make a flame graph out of it and the result was non sense; I removed it, but haven't updated our xhgui yet) [22:14:03] anomie hi, does this Special:ListFiles work for you in actor? (searching by usernames) [22:14:44] it dosen't seem to work when i search by username [22:14:49] but does work if no username is entered [22:20:03] https://github.com/wikimedia/mediawiki/blob/master/includes/specials/pagers/ImageListPager.php#L137 [22:20:07] i guess that must be it? [22:21:12] i think so, seeing as img_user_text is empty. [22:23:28] filled https://phabricator.wikimedia.org/T211061 [23:15:40] anomie: <3