[10:11:40] <Hauskatze>	 Can we post the trace for T210985 ?
[10:11:41] <stashbot>	 T210985: Fatal exception of type "InvalidArgumentException" when querying for Special:Contributions - https://phabricator.wikimedia.org/T210985
[10:11:51] <Hauskatze>	 (I don't have logstash access)
[15:58:43] <_joe_>	 what is the best and fastest way to understand if we're on HHVM or php-fpm from php code?
[16:00:20] <bd808>	 _joe_: defined( 'HHVM_VERSION' );
[16:00:57] <bd808>	 that will be true in an HHVM runtime and false otherwise
[16:01:28] <bd808>	 wfIsHHVM() === return defined( 'HHVM_VERSION' );
[16:02:56] <_joe_>	 bd808: ok context is https://phabricator.wikimedia.org/T211184
[16:03:52] <_joe_>	 I would add to the auto_prepend_file if (! defined( 'HHVM_VERSION' ) ) { openlog('php-fpm', ...); }
[16:10:28] <_joe_>	 bd808: thanks for the info, in fact that's probably the fastest way to check something like that in php
[16:10:45] <bd808>	 yeha, it should be a really low runtime cost
[16:43:19] <bpirkle>	 legoktm: did you get a chance to look over the guzzle-related changes last night?
[16:43:44] <_joe_>	 bpirkle: oh hey can I steal your attention for 5 minutes?
[16:44:00] <_joe_>	 what is your endpoint for testing error logging in php?
[16:44:17] <_joe_>	 sadly php-fpm has its own set of problems compared to CLI
[16:44:40] <_joe_>	 so we'll need to do some testing there too
[16:44:53] <_joe_>	 once I fixed logging, that is
[16:44:59] <_joe_>	 :P
[16:45:47] <bpirkle>	 _joe_: absolutely.  For now, I'm just kinda hit-and-miss via eval.php.  Once the new little script is live, it looks like it will be urls of the form https://test.wikipedia.org/w/fatal-error.php?password=foo&action=nomethod&postsend=no
[16:46:31] <_joe_>	 uh the password in get?
[16:46:54] <_joe_>	 that would get into the logs
[16:47:33] <_joe_>	 can't we send it as basic auth, and verify the Authentication: header in php?
[16:47:49] <_joe_>	 anyways, once you feel it's ready, ping me :)
[16:48:15] <_joe_>	 (I'm in CET/CEST, so I go offline around this time of the day)
[17:01:16] <bpirkle>	 Sorry, distracted by doorbell.  Password in logs is an excellent point - I'll revisit with that in mind.
[18:58:31] <paladox>	 bpirkle hi, wondering if you could review/merge https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/477578/ please? :)
[18:58:43] <paladox>	 I've tested it on REL1_31 and seems to work .
[20:43:35] <bpirkle>	 paladox: done
[20:43:54] <paladox>	 bpirkle thank you!!
[21:39:58] <paladox>	 bpirkle could you also review / merge https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/477908/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/477907/ please? (they are backports of the change)
[21:50:02] <bpirkle>	 paladox: done
[21:50:05] <paladox>	 thanks!