[00:15:17] I just stumbled into this: https://www.mediawiki.org/wiki/Skin:BootStrapSkin [00:15:26] isn't that a license violation? [00:15:31] a defunct one, even [00:16:15] tgr: What makes it a violation? [00:17:03] tgr: http://getbootstrap.com/ says Bootstrap is MIT (though I note the skin's screenshot image doesn't state a licence, tsk). [01:20:07] James_F: I guess technically you can keep a GPL-ed extension secret and sell it for money as long as you don't prevent others from publishing the code, but it's a strange thing to do [01:21:20] oh wait it is on github [01:21:34] what does "commercially available" mean then? [01:22:01] GPL doesn't prevent sale. That's RedHat's business model [01:27:20] bd808: the download link in the extension infobox goes to a password-protected page, wich is a bit different from RedHat [01:27:47] but it seems like that's just some kind of webpage admin screwup and the code is actually available [01:29:05] its not a GPL violation until you sell somebody something the is GPL and you don't provide them source code. GPL doesn't by default mean that the code has to be available to the universe, just that once you give it to someone they can choose to exercise the 4 freedoms [01:36:01] it's not a viable business model either, so if someone did it, I would be suspicious that they are not honest about their license claim [07:08:04] <_joe_> TimStarling: can't we load tideways with dl() if it slows down everything just by being loaded? [07:08:19] <_joe_> as in: we install the software but disable the extension [07:12:50] <_joe_> ahha the function has been removed from php in 7.0 [07:12:52] <_joe_> meh [09:42:14] _joe_: dl() was always buggy, and there was a security issue in which it could be used to attack the apache host process by loading a crafted extension [09:43:17] the hook in question is a true global, which means if you use a threaded SAPI module, it can't be disabled in one request but enabled in another concurrent one [09:43:54] <_joe_> I think php-fpm uses a prefork model, it doesn't use threads [09:44:06] yeah, I don't think we use that [09:45:20] <_joe_> anyways, I'll install the package everywhere and load the extension only on the mwdebug servers [09:46:12] I should mention that I haven't actually tested the performance degradation of installing tideways, it's just a fairly plausible theory based on a report from Krinkle that tideways is bad for performance [09:46:38] if you install the package then I guess we can benchmark it on a production server [09:48:44] and you are installing php-mongodb? we probably can't use it immediately, but we can switch over to it once HHVM is gone [09:50:04] looks like you saw my comment [09:50:08] bbl [09:58:37] <_joe_> ok, so I am first building the package, I'll benchmark the change in performance when enabling the extension [18:40:28] <_joe_> TimStarling: my tests seem to show no effect due to just having the tideways extension loaded [18:40:37] <_joe_> on monday I'll upload the results [19:58:15] anomie hi, im wondering if you can take a look at https://phabricator.wikimedia.org/T211450 please? :) [19:59:33] paladox: See if https://gerrit.wikimedia.org/r/c/mediawiki/core/+/476508 fixes it. If so, it's a duplicate of T210621. [19:59:34] T210621: Internal api error: CannotCreateActorException - https://phabricator.wikimedia.org/T210621 [19:59:49] oh [19:59:50] thanks! [20:01:01] anomie so that will fix it for 1.31? [20:01:42] That particular exception anyway, probably. [20:02:08] thanks! [20:24:16] anomie dosen't seem to work [20:32:00] anomie i think it is caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/476508/2/includes/user/User.php@2537 [20:40:55] i think it's because of "dial-xxx-x-xxx-xx.netcologne.de" [20:41:13] that was someone's id (in ) [20:42:09] paladox: Try backporting 986dfa8f35188a89546b598f42b2d6840fb7af94 [20:42:44] ah [20:42:47] * paladox trys [20:44:47] anomie still fails [20:44:51] with same error [20:45:24] paladox: Sanity check: Are you actually using the --username-prefix option? [20:45:30] yup [20:45:37] sudo -u www-data php /srv/mediawiki/w/maintenance/importDump.php --wiki=s23wiki --report=1 --uploads --username-prefix="s23" s23wiki_20181207.xml [20:46:12] Then you'll have to do some debugging to figure out how it's getting there without prefixing the username, or how it's thinking the user doesn't exist when it actually does. [20:46:45] anomie i think it's choking on "dial-xxx-x-xxx-xx.netcologne.de" [20:46:58] where x is numbers [20:49:26] it's a hostname containing a ip [20:52:33] anomie https://github.com/wikimedia/mediawiki/blob/master/includes/user/User.php#L1002 [20:52:37] it's likley failing there [20:56:46] paladox: Did you test things to see if it's "failing" there, or are you just guessing? [20:56:58] just a guess [20:57:09] You should test things. [20:57:42] I followed [20:57:43] if ( $q['actor_user'] === null && self::isUsableName( $q['actor_name'] ) ) { [21:08:09] anomie i've debugged it a little bit [21:08:17] and found it's returning null in my test [21:08:20] *false [21:08:31] > var_dump( User::isValidUserName( null ) ); [21:08:31] bool(false) [21:09:17] And you're passing null as the parameter rather than "dial-xxx-x-xxx-xx.netcologne.de" because? [21:09:55] because here > var_dump( User::isValidUserName( 'Netcologne' ) ); [21:09:55] bool(true) [21:09:57] * [21:10:00] https://github.com/wikimedia/mediawiki/blob/954327b642fcf869aab7fa75dd58a82935f9d2e1/includes/user/User.php#L2533 [21:10:35] oh [21:10:37] $q['actor_name'] is being passed, not $q['actor_user']. [21:10:53] And a false return there wouldn't make it throw that exception anyway. [21:10:58] just realised that sorry :) [21:11:07] yeh [21:11:13] if it was true it would make it throw [21:12:47] oh [21:12:48] found it [21:12:50] > var_dump( User::isUsableName( 'Mutante' ) ); [21:12:50] bool(true) [21:13:00] capitals are making it return true [21:16:06] paladox: Sanity check: Does that "dial-xxx-x-xxx-xx.netcologne.de" username exist in your user table? [21:16:13] nope [21:16:18] but that passed User::isUsableName [21:16:42] Then you probably need to figure out why https://github.com/wikimedia/mediawiki/blob/REL1_31/includes/import/WikiImporter.php#L933 isn't applying the prefix to it. [21:17:43] oh [21:41:36] oh [21:41:40] that's probaley why: [21:41:50] [21:41:51] dial-xxx-x-xxx-xx.netcologne.de [21:41:51] 0 [21:41:51] [21:41:56] shoulden't that be ? [21:42:35] no [21:46:49] ah ok [21:53:24] anomie ah [21:53:26] found it [21:53:28] tested [21:53:36] it's https://github.com/wikimedia/mediawiki/blob/REL1_31/includes/user/ExternalUserNames.php#L77 [21:53:47] as soon as i add $this->addPrefix( $name ); [21:53:48] it works [21:54:21] paladox: Why is User::isUsableName() returning false there but true later on? Is it not getting the same name? [21:54:43] anomie im not sure. [21:57:59] paladox: ... Actually, it's probably *not* being passed the same name. The version being passed into applyPrefix() has a lowercase 'd' at the start. [21:58:10] ah [21:58:14] While the version later on will probably have gotten uppercased. [21:58:26] Why does your file have lowercase in the anyway? [21:58:59] Anyway, time for me to get off work. I have things to do. [21:59:04] I guess it's from the old mw version.