[01:33:58] subbu: fyi Tim is on break now [04:00:24] legoktm, ah ok. ty. [05:02:13] yeah, haven't changed my nickname yet [05:02:43] have to set vacation mode in gmail [05:27:15] thanks for the reminder, just did mine [17:01:36] Krinkle: Do you have any more comments on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/475593/? [17:03:05] anomie: hi, wondering when you get a chance, could you review/merge https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/480822/ please? :) [17:03:13] (Only if you have a chance :)) [17:06:26] Thanks! [17:27:11] anomie: he told me in an email that he'd like to understand the code better, but we don't need to wait for him with merging it [17:27:20] i'll forward the mail to you [18:07:31] <_joe_> duesen__: did you get your laptop back? :) [18:10:24] _joe_: sure, it was sitting on my desk in the office. i just forgot to take it home, so i would have it there for the meeting at 7am :) [19:18:36] anomie: I do not, for the record. [23:03:15] Tim-away, ingore my previous question .. it wasn't a remex issue but a json_encode issue .. https://secure.php.net/manual/en/function.json-encode.php .. we were missing JSON_UNESCAPED_SLASHES and JSON_UNESCAPED_UNICODE in our internal uses .. so just make it a helper so we don't run into this again (2nd time now). [23:03:56] s/make/made [23:05:11] subbu: fwiw MW has the FormatJson class as a wrapper: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/includes/json/FormatJson.php [23:07:20] ok .. for now, we have a phputils class that have some helpers .. the plan is for this to be a composer lib so those classes won't be available to parsoid .. we can figure out later how to expose some of these to parsoid. [23:30:54] at some point we need to figure out how to librarize Message and StatusValue [23:31:24] once we do that, utility classes like FormatJson can easily be exposed as composer packages