[21:08:21] <paladox>	 Reedy hi, wondering if you could review/merge https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageTriage/+/479995/ please? :)
[21:10:09] <paladox>	 thanks!
[21:12:55] <paladox>	 Reedy could you also review/merge https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/478365/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/478363/ please? :)
[21:20:31] <paladox>	 Reedy could you also review/merge https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/481503/ please? :) (to fix a test failure https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/3826/console (hopefully))
[21:22:56] <paladox>	 thanks!
[21:26:47] <paladox>	 hmm phcs for https://integration.wikimedia.org/ci/job/release-quibble-vendor-mysql-php73-docker/5/console seems to be checking the vendor folder of echo.
[21:26:58] <paladox>	 Shoulden't we be adding vendor to the ignore list?
[21:28:12] <Reedy>	 Yeah
[21:28:20] <Reedy>	 I think it's mostly done manually though where necessary
[21:28:31] <Reedy>	 "parallel-lint --exclude vendor ."
[21:28:32] <Reedy>	 or similar
[21:28:55] <paladox>	 ah 
[21:28:55] <paladox>	 ok
[21:29:29] <Reedy>	 I'm not exactly sure why lego's updater script hasn't been updated to add that.. Maybe just because it's not been enough of an issue in most cases
[21:29:34] <Reedy>	 But maybe it should be done :)
[21:30:33] <Hauskatze>	 add paralel-lint --exclude vendor to composer.json ?
[21:30:52] <Hauskatze>	 I guess we can add it to libraryupgrader
[21:31:11] <Reedy>	 Most will/should have it, without the vendor part
[21:32:53] <paladox>	 Reedy https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/481506/ :)
[21:34:01] <Reedy>	 oh, phpcs
[21:34:08] <Reedy>	 I didn't actually look at the failing part
[21:34:29] <paladox>	 heh
[21:34:55] <Reedy>	 This feels slightly dejavu
[21:35:01] <Reedy>	 But we don't have that in mw cores .phpcs
[21:35:24] <paladox>	 oh
[21:35:39] <paladox>	 Reedy does the php7.3 test pass in mw core?
[21:35:46] <Reedy>	 Not sure
[21:35:51] <Reedy>	 But that code doesn't look unfamiliar
[21:36:46] <paladox>	 ok
[21:37:19] <Reedy>	 Yeah, at least 50 other extensions have it
[21:37:25] <Reedy>	 Will wait for jerkins and then can merge it
[21:37:39] <paladox>	 thank! :)
[21:37:52] <paladox>	 Reedy could you re +2 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageTriage/+/479995/ please? :)
[21:37:59] <paladox>	 now that the echo change has been merged
[21:44:07] <paladox>	 it passed under 7.3!
[21:45:14] <Reedy>	 Have PHPCS fixed it upstream OOI?
[21:45:25] <Reedy>	 I saw you make a patch to bump phpcs version then abandoned it
[21:45:38] <paladox>	 I think they did
[21:45:45] <paladox>	 i was looking and saw it as continue 2
[21:46:02] <paladox>	 it was a few more lines down then what was said in the failed test
[21:46:15] <paladox>	 but i didn't see "php7.3 fixes" in the release notes.
[21:49:32] <Reedy>	 https://github.com/squizlabs/PHP_CodeSniffer/compare/3.3.2...3.4.0
[21:49:38] <Reedy>	 They are testing on PHP 7.3 now
[21:49:54] <Reedy>	 https://github.com/squizlabs/PHP_CodeSniffer/commit/16c771d0ac0b4c3e425a4f9c9533d96832e0f08d
[21:49:57] <Reedy>	 Suggests they fixed some..
[21:50:35] <Reedy>	 Continue looks to have gone in master
[21:50:55] <paladox>	 ah
[21:51:02] <paladox>	 thanks! didn't check that far back
[21:51:17] <paladox>	 oh that's probaley why
[21:51:35] <paladox>	 echo on the 1.31 branch would be using a older phpcs version then the master branch.
[21:51:41] <Reedy>	 Possibly
[21:51:57] <Reedy>	 Also, we've not bumped to phpcs 3.4.0 across our fleet either
[21:52:17] <Reedy>	 https://github.com/wikimedia/mediawiki-tools-codesniffer/compare/v23.0.0...master
[21:52:38] <Reedy>	 But yeah, excluding vendor is the sensible fix
[21:52:54] <paladox>	 yup :)
[21:57:22] <paladox>	 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageTriage/+/479995/ passes test (though im not sure how to get it to test in "quibble-vendor-mysql-php72-docker")
[21:59:12] <paladox>	 thanks!
[22:02:18] <paladox>	 hmm, fails again
[22:02:19] <paladox>	 22:01:55 1) EducationProgram\Tests\SpecialsTest::testSpecial with data set #0 (EducationProgram\SpecialCourses Object (...))
[22:02:19] <paladox>	 22:01:55 count(): Parameter must be an array or an object that implements Countable
[22:02:23] <paladox>	 oh
[22:02:30] <Reedy>	 screw EP :)
[22:03:51] <paladox>	 lol
[22:05:13] <paladox>	 oh heh Reedy you fixed it already
[22:05:14] <paladox>	 :)
[22:05:15] <paladox>	 I57ce435491c64acc2dcff59f304e41c7920e09cf
[22:05:34] <paladox>	 cherry picked it here https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EducationProgram/+/481507/
[22:05:35] <paladox>	 :)
[22:07:27] <paladox>	 thanks :)
[22:13:09] <paladox>	 Reedy could you re +2 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageTriage/+/479995/ please? hopefully it will work this time :)
[22:22:57] <paladox>	 Reedy passes now https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/3831/console :)
[22:23:08] <paladox>	 (figured out check php runs the test too)
[23:35:52] <paladox>	 Reedy wondering could you +2 https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/478365/ please? (it's for 1.31) :)
[23:37:40] <paladox>	 thanks! Reedy could you also re +2 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageTriage/+/479995/ please? :) (i've ran check php which passed)
[23:39:04] <paladox>	 thanks!
[23:52:56] <paladox>	 Reedy wondering if you could also review https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ContributionScores/+/477701/ please? :) (the author of it is not on gerrit and has not be active on wiki) (i've tested it and it works)