[23:49:11] tgr: are you around? I've got an AuthManager related question and saw you sending patches to gerrit :) [23:49:25] yes [23:49:50] I'm trying to figure out why createAndPromote is failing for LdapAuth and now wondering how it ever worked. [23:50:41] the problem is that createAndPromote acts on User directly and never calls into the custom "addUser" function in LdapAuth [23:52:01] I see you commented on the bug I opened about it :) [23:52:24] yeah, no clue what changed there [23:52:40] I imagine addUser should be called in the LocalUserCreated hook [23:53:02] * bd808 looks to see if that is even wired up [23:53:23] hm, we did remove a bunch of deprecated hooks recently, maybe that affected things that are using the old AuthPlugin interface [23:53:43] that's kind of what I've been trying to trace through... [23:55:01] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/441513 [23:55:13] not that LdapAuth seems to use any hooks whatsoever [23:55:47] and none of these seem like a sane place for user creation... [23:55:58] It registers them weirdly in the constructor of LdapPrimaryAuthenticationProvider [23:56:58] If LocalUserCreated fired I think things would work, but the flow in createAndPromote does not seem to talk to AuthManager in a way that would fire that one [23:57:46] The user is created there via $user->addToDatabase() [23:58:35] so the local user is made, but LDAP (or any other AuthProvider) is never told to do anything about the creation