[14:24:13] <kostajh>	 ping legoktm 
[18:09:30] <legoktm>	 kostajh: hi
[18:10:28] <kostajh>	 legoktm: hi! I'm about to go into a meeting but was wondering if we could chat about T212771
[18:10:28] <stashbot>	 T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter" - https://phabricator.wikimedia.org/T212771
[18:11:14] <legoktm>	 what's up?
[18:11:52] <legoktm>	 we probably should revert the original change as a breaking one
[18:12:28] <kostajh>	 what are your thoughts on adding getters to the private properties?
[18:12:54] <kostajh>	 that is fairly low impact
[18:14:34] <legoktm>	 it's probably fine
[18:14:38] <kostajh>	 alternatively, we could add $pagerOptions (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/481891) as 6th parameters to the reallyDoQuery hook and keep $this in there (marking it as deprecated), but doesn't seem great
[18:15:16] <legoktm>	 I would suggest adding a new hook with the signature that we want, and deprecating the old one
[18:16:28] <legoktm>	 so https://gerrit.wikimedia.org/r/c/mediawiki/core/+/480992/ and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/480995/ need to be reverted as a first step
[18:18:16] <kostajh>	 ok
[18:18:46] <paladox>	 legoktm hi, im wondering if you cold  force merge  https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Renameuser/+/482084/ please? :)
[18:19:09] <paladox>	 test failures happen on master too
[18:19:19] <paladox>	 so i filed https://phabricator.wikimedia.org/T212876
[19:46:11] <paladox>	 Reedy: hi, wondering if you can merge https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UserMerge/+/482110/ (and force merge https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Renameuser/+/482084/ ) please?
[19:46:59] <paladox>	 :)
[20:10:38] <kostajh>	 legoktm: I submitted https://gerrit.wikimedia.org/r/c/mediawiki/core/+/482119 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/482120