[00:22:58] James_F: 1.0, 0.10, or 0.91? [00:23:03] 0.9.1* [00:23:30] * James_F looks. [00:24:12] Krinkle: 0.10.0. [02:14:11] James_F: https://gerrit.wikimedia.org/r/#/c/performance/fresnel/+/482748/ [02:14:12] https://github.com/qunitjs/qunit/issues/1342 [02:14:26] that was my December project ;-) [02:15:05] Krinkle: Woah. [02:15:12] Krinkle: Should we bump MW's versions? [02:16:05] It could literally save someone from having their ssh credentials compromised. A big motivation was to make sure QUnit isn't the next victim of someone compromising an obscure package like is-array that is used all over the place. [02:16:18] * James_F nods. [02:16:57] also upstream-upstream nodejs is doing some funky things with filename strings https://github.com/nodejs/node/issues/25290 [02:17:33] will be fixed in the next libuv for Node 12 probably [02:18:08] Lovely. [19:15:30] [18:14:12] https://github.com/qunitjs/qunit/issues/1342 <-- that is awesome [19:17:39] legoktm: Indeed. :-) [19:17:54] (And now merged into MW core, so used in our CI.) [19:17:55] I wish every maintainer sat down and did similar analysis [20:07:00] I ran into a problem with https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/481115#message-a61f99d885208bead052e485fbd5bad95ceda34f where I'd need to fetch an array of wiki => settings from WMF config, instead of just the settings for the current wiki [20:07:06] is there a sane way to do that? [20:11:37] $globals = $wgConf->getAll( $wgDBname, $dbSuffix, $confParams, $wikiTags ); [20:12:24] I'm not sure that's sane though [20:19:27] doesn't that give all settings for one wiki? [20:19:34] I need one setting for all wikis [20:20:35] also my impression was that SiteConfiguration is mostly broken and only guaranteed to work for some small subset of config keys [20:21:59] I guess I could just iterate through all the wikis where the user has a non-standard group and call $wgConf->get, but is that reasonable performance-wise? [20:24:43] Ah, you want the other way round [21:38:20] tgr: The only breakage in SiteConfiguration that I know about is to do with trying to override a non-null with null. But there could be stuff I don't know about. Anyway, if this is for $wgPrivilegedGroups, can you just punt and document that it needs to be set the same on all wikis? [21:39:37] I suppose the real breakage in depending on $wgConf is that third parties might be ignoring it in favor of explicit "if" logic in LocalSettings.php or the like. [21:40:01] anomie: yeah, I'll probably end up doing that. I'm pretty sure there is some reason server / DB name can be fetched for any wiki but arbitrary config keys can't; not sure if that's a SiteConfiguration issue or some other config stuff I'm confusing it with [21:41:14] tgr: Part of the trick in using $wgConf->get() might be that you have to pass the right values for $params and $wikiTags. Just leaving them blank or using the current wiki's values won't work. [21:41:51] also there is some horrible thing about configuration reads sometimes ending up invoking a CLI script which is not very robust? [21:42:20] For ->getConfig() you mean? [21:42:35] I don't remember what exactly [21:43:06] I wanted to avoid security logspam as for example templateeditor can edit the interface in some wikis but is fairly harmless on others [21:43:50] but just merging everything together into a big array is still not that bad [22:36:57] James_F: do you have time to +1 the changes to the policy config patch? https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/481115/4..11 [22:37:26] tgr: Looking. [22:39:28] thx [22:39:31] tgr: Seems sane. Was following along the patchsets yesterday. [22:44:44] James_F: https://github.com/wikimedia/grunt-banana-checker/issues/13 [22:45:17] Krinkle: Ooh, thanks. [22:45:51] Krinkle: An approve on https://github.com/wikimedia/grunt-banana-checker/pull/63 would be nice though. ;-) [22:46:00] James_F: yeah, next up :) [23:19:26] James_F: https://github.com/wikimedia/grunt-banana-checker/pull/65 , and then release? [23:20:31] Krinkle: WFM. [23:21:13] Krinkle: Don't suppose you have magic reach to zaach/jsonlint's author? ;-) [23:31:09] James_F: nope [23:31:34] Yeah, never mind.