[00:00:15] Reedy i always pull in the whole 1.32 branch. [00:05:59] heh you got to it before me :) [00:18:24] Reedy would you be able to merge https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/erudite/+/483851/ please? :) [00:18:34] that should fix support for mw 1.32+ [00:20:36] Isn't that needed on master too? [00:21:12] oh heh i didn't do it on master [00:21:18] but i think we can merge up [00:21:32] Didn't do what? [00:21:42] https://github.com/wikimedia/mediawiki-skins-erudite/blob/master/Erudite.skin.php#L158 [00:22:02] i didn't do the change on master [00:22:09] instead did it on 1.32 :) [00:22:23] But that's what I'm saying, isn't it broken on master too? [00:23:12] yup [00:23:13] https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/erudite/+/483882/ [00:23:19] done on master now too ^^ [00:23:52] Cherry pick? [00:24:35] yup, will do that [00:24:45] i'll abandon the one i did on 1.32 and do a cherry pick [00:25:12] https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/erudite/+/483883/ [00:25:39] thanks! [00:29:25] also added RL notes to https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/483859/ [00:39:47] Reedy that's fixed the spammy message (monitoring to see if it fixes the other spammy messages too) [00:39:48] 10MediaWiki-Core-Team, 10Performance-Team (Radar): [bug 64767] Optimistic save API/JS - https://phabricator.wikimedia.org/T1096 (10Krinkle) [00:43:43] .... I think someone forgot to remove a bot configuration. [01:01:26] Reedy i've been monitoring for 30mins now and it seems the spammy messages have gone (all of them) [01:01:37] heh, nice [01:43:37] eprodromou seems your connection is broken :) [01:43:41] oh they left [01:43:48] eprodromou seems your connection is broken :) [01:44:17] Reedy it's been a hour now and no spammy messages (so it worked!) [01:54:13] eprodromou: poke [01:54:19] sigh [01:56:57] had to look that up, been a long time since I did a banforward... [23:05:58] Reedy 24 hours and spam is not showing! :) [23:35:25] paladox: Probably close your task then [23:35:31] yup [23:35:35] My task for the followup .1 release will stay open :) [23:36:27] heh