[16:03:48] <duesen>	 James_F: do you think we can just merge that? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/472486
[16:03:54] <duesen>	 this has been bugging me for years :/
[16:06:06] <James_F>	 duesen: Sure, butit definitely needs release notes.
[16:06:20] <James_F>	 duesen: And I just fiddled with the commit message for spelling. :-)
[16:10:00] <duesen>	 so did I, twice. it was terrible!
[16:10:08] <duesen>	 uh, yea, release notes. will do that.
[16:19:43] <James_F>	 duesen: Eurgh, why must you write in localised en-US? ;-)
[16:23:03] <duesen>	 you mean, behavior not to behavi?
[17:03:40] <KateChapman>	 bpirkle: SRE is blocked on this for php7. Is this something you could do? https://phabricator.wikimedia.org/T213934
[17:05:49] <Reedy>	 Didn't we do this for HHVM? I can't remember if we exposed it as a betafeature
[17:06:19] <Reedy>	 Yes, we did
[17:07:43] <Reedy>	 KateChapman: I found the code for it :P
[17:07:43] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/commit/b552e154a4cbe92de97fd538b0b32bd0e3401be5
[17:08:07] <KateChapman>	 that is the first step. thanks Reedy
[17:08:59] <Reedy>	 Shouldn't take long to turn that into something
[17:12:08] <LarryTheCat>	 Reedy: does https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/484275/ look right to you
[17:28:00] <_joe_>	 Reedy: I'm working on it with James_F now FTR :)
[17:28:06] <Reedy>	 Pfft
[17:28:11] <Reedy>	 I just made a patch doing most of it
[17:28:15] <_joe_>	 oh good
[17:28:21] <_joe_>	 so we just ned the icon?
[17:28:23] <James_F>	 Reedy: Show-off. :-)
[17:28:23] <_joe_>	 :D
[17:28:31] <_joe_>	 *need
[17:28:33] <Reedy>	 I didn't look what the old one was
[17:28:33] <Reedy>	 https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/9a6f2e9697339e2e3fe9195c6478d5fd1ffa6af1/betafeatures-HHVM-ltr.svg
[17:28:43] <Reedy>	 We could reuse that, as there's nothing HHVM specific in it
[17:28:43] <James_F>	 _joe_: We need the Varnish stuff to read the "php7" cookie.
[17:29:12] <James_F>	 The old icon is based on the old standard. We'd need to update it anyway.
[17:29:20] <Reedy>	 Heh
[17:29:33] <James_F>	 I've ping Ed to make one.
[17:29:46] <_joe_>	 James_F: what do you mean with "varnish stuff"?
[17:29:57] <_joe_>	 varnish is set up to separate caches between hhvm and php7
[17:30:19] <James_F>	 I mean routing differently based on cookie.
[17:30:30] <_joe_>	 that's not done at the varnish layer this time
[17:30:35] <_joe_>	 it's done in apache
[17:30:41] <_joe_>	 on the appserver
[17:30:55] <_joe_>	 based on the cookie, we send the parsing request to hhvm or php-fpm
[17:31:14] <James_F>	 Oh, OK. In that case, we need that code.
[17:31:22] <James_F>	 Is that already implemented?
[17:31:24] <James_F>	 Nice.
[17:31:26] <_joe_>	 yes
[17:31:32] <_joe_>	 everything is in place
[17:31:43] <_joe_>	 apart from profiling I think 
[17:32:03] <_joe_>	 now, I fully expect people to find weird and potentially harmful bugs :)
[17:33:39] <_joe_>	 if I can deploy the beta feature on monday, I hope after all-hands we might start a/b testing with like 0.5% of users sent to php7
[17:34:03] <_joe_>	 I need to write that patch
[17:36:55] <James_F>	 Well, to get it into prod on Monday we'd need to back-port, but that's do-able.
[17:38:04] <_joe_>	 ack
[17:38:13] <Reedy>	 full scap because new messages
[17:38:19] <_joe_>	 argh
[17:38:26] <James_F>	 Yeah, but not a real risk.
[17:38:33] <James_F>	 Just half an hour rather than half a minute.
[17:38:34] <_joe_>	 yeah, just annoying
[17:38:40] <_joe_>	 sigh
[17:38:49] <James_F>	 Will also need to add to James's magic whitelist for beta features. :-)
[17:39:01] <James_F>	 (Also also Monday is a holiday, but…)
[17:39:04] <_joe_>	 what is that?
[17:39:05] <_joe_>	 oh, ok
[17:39:09] <_joe_>	 tuesday
[17:39:10] <Reedy>	 HOLIDAYS DO NOT STOP THE DEPLOYS
[17:39:12] <_joe_>	 sorry I forgot
[17:39:15] <_joe_>	 MLK day
[17:39:17] * Reedy hides from greg-g
[17:39:34] <Reedy>	 const PHP7_START = 1412726400;  // Wed, 08 Oct 2014 00:00:00 UTC
[17:39:52] <Reedy>	 Do we want to opt new users in like this?
[17:39:58] <_joe_>	 Reedy: I don't remember ori being scared away by holidays or weekends
[17:40:03] <James_F>	 _joe_: wgBetaFeaturesWhitelist
[17:40:12] <Reedy>	 _joe_: I'm also not scared by deploying on trains, planes, boats...
[17:40:16] <James_F>	 _joe_: You're talking to Reedy, who famously deployed from a ship.
[17:40:21] <James_F>	 [in]famously.
[17:40:24] <_joe_>	 and on a plane
[17:40:32] <Reedy>	 Planes are boring to deploy from now
[17:40:34] <Krenair>	 I think Chad did it from a car once?
[17:40:48] <Reedy>	 I've done the whole train from a carpark before too
[17:40:49] <Krenair>	 or was that just IRCing
[17:40:50] <James_F>	 It was going great up until the network dropped half way between France and the UK in the middle of a scap.
[17:40:57] <Krenair>	 I mean a moving car
[17:40:57] <_joe_>	 well I have worked on outages in weird places repeatedly
[17:41:00] <Reedy>	 lolol, shhh
[17:41:07] <_joe_>	 James_F: ahahahahah
[17:41:26] <_joe_>	 Reedy: tmux is your friend!
[17:42:04] <_joe_>	 Krenair: I'm pretty sure I debugged an HHVM deadlock from a moving car
[17:42:45] <Krenair>	 wow
[17:42:55] <_joe_>	 I wasn't driving
[17:43:02] <_joe_>	 and it was within the city
[17:43:07] <_joe_>	 so not so impressive
[18:02:59] <James_F>	 _joe_, Reedy: Updated with icons, courtesy of Ed.
[18:06:32] <_joe_>	 thanks :)
[18:15:30] <LarryTheCat>	 [18:40:32] <Reedy> Planes are boring to deploy from now <-- depends on if you have to pilot and deploy code ;-)
[18:16:03] <LarryTheCat>	 Last week I was next to a Beechcraft King Air
[18:38:46] <bpirkle>	 KateChapman: Sorry I was in a (very cool) meeting about local dev envs.  Looks like Reedy already jumped on the task, but if there's anything I can do to help, let me know.
[18:39:14] <KateChapman>	 bpirkle np yeah I think it has been taken care of
[18:47:11] <LarryTheCat>	 I think we should cherry-pick https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/484275/ to REL1_32 but gerrit won't let me due to a "merge conflict".
[18:47:22] <LarryTheCat>	 Do you think we should cherry-pick it?
[19:22:47] <LarryTheCat>	 when the db mocks at you: "[XD@DcApAAD4AADuhSyEAAAAU] 2019-01-16 19:18:09: Fatal exception of type MWException"
[19:23:05] <LarryTheCat>	 (known issue afaics)
[19:53:36] <hashar>	 tgr: hello!  In theory Gerrit should not add reviewers based on git blame :)  That was a task from June 2015 ( https://phabricator.wikimedia.org/T101131 )
[19:54:13] <tgr>	 hashar: should not add or should now add?
[19:54:20] <hashar>	 should now add :)
[19:54:24] <hashar>	 sorry I am tired
[19:54:34] <hashar>	 and apparently the plugin is configurable on a per repository basis
[19:55:19] <tgr>	 that's awesome, thanks for working on it!
[19:57:26] <hashar>	 tgr: if you see something odd, feel free to reopen the task or fill a subtask ;)
[19:57:29] <hashar>	 and we can dig into it
[19:57:43] <hashar>	 I hope that would help with reviews
[21:02:39] <Nemo_bis>	 Looks sweet
[21:46:01] <Krinkle>	 subbu: What is `                        tplData = apiResp && apiResp[Object.keys(apiResp)[0]];` supposed to do
[21:46:29] <Krinkle>	 does that operate on the api resposne object containing { batchcomplete: '', pages: { .. }} or on .pages only?
[21:52:25] <Krinkle>	 Hm.. I guess just .pages, given the logged object. 
[22:16:13] <subbu>	 Krinkle, in meeting .. will chat after.
[23:23:29] <James_F>	 _joe_, Reedy: Have made https://www.mediawiki.org/wiki/Beta_Features/PHP7 for you to tell users why we're moving to PHP7. :-)
[23:34:44] <Reedy>	 Our preliminary benchmarks[2] show that HHVM is significantly faster than the current PHP interpreter.
[23:35:16] <Reedy>	 James_F: You did as good of a job as me at replacing the text ;P
[23:35:42] <paladox>	 "and checking that it says "HHVM" instead of "PHP" in the "Installed software" table."
[23:35:48] <James_F>	 I didn't replace anything after the first paragraph. :-)
[23:35:53] <paladox>	 heh
[23:36:53] <Reedy>	 James_F: You just reverted my changes :(
[23:37:32] <James_F>	 Reedy: To what?
[23:37:42] <Reedy>	 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaEvents/+/484710/11..12
[23:40:38] <Reedy>	 James_F: What was your last change? SVG updates?
[23:41:02] <James_F>	 Reedy: Oh, right, fuck gerrit.
[23:41:07] <Reedy>	 ahaha
[23:41:18] <James_F>	 "Hey, yes, git review -dfoo,bar was great, so we killed it! You're welcome!"
[23:41:49] <James_F>	 Sorry, makes it a mess to revert.
[23:42:15] <James_F>	 I un-commented the SVG links and added values for info-link and discussion-link
[23:42:29] <Reedy>	 Easy to fix then
[23:42:40] <Reedy>	 let me do it
[23:47:15] <Reedy>	 James_F: Do we want a wgPoweredByHHVM type JS var? 
[23:47:26] <Reedy>	 Just looking at ori's other HHVM related commits in that repo
[23:51:42] <James_F>	 Reedy: Nah, that gadget was janky.
[23:51:49] <Reedy>	 hahah, fair
[23:51:56] <Reedy>	 I think the patch is roughly good to go now
[23:52:06] <Reedy>	 I've put the "start date" to Tuesday for now at least
[23:52:17] * James_F grumbles at having to re-write everything that Reedy deletes in https://www.mediawiki.org/w/index.php?title=Beta_Features/PHP7&diff=3056939&oldid=3056935&diffmode=visual
[23:52:31] <James_F>	 Reedy: Didn't we want to back-port-deploy on Monday? :-D
[23:52:43] <Reedy>	 I wasn't sure with holidays and stuff
[23:52:46] <Reedy>	 Monday WFM too