[07:25:43] what's the least painful way of creating a l10n message for a unit test? [07:27:13] tgr: how real does it need to be? if it's just for output, you can set language to qqq and assert the key is the same [07:27:57] or mock MessageLocalizer, or if it needs to be a real one, I think you can mess with MessageCache::singleton() [07:28:29] it's error handling related so I think the language gets normalized to en [07:28:56] https://gerrit.wikimedia.org/g/mediawiki/core/+/9d8ecd813f5df2a032cba99b0c95b85feab3457b/tests/phpunit/includes/api/ApiQuerySiteinfoTest.php#165 and the next few lines [07:30:48] https://gerrit.wikimedia.org/g/mediawiki/extensions/CirrusSearch/+/373eb837ffd1b1e8bba695cbd5bc6bf9489920e3/tests/phpunit/UtilTest.php#86 is another approach [07:31:30] SpamBlacklist uses the first approach (enable MessageCache and edit the MW namespace) [07:31:40] (found via https://codesearch.wmflabs.org/search/?q=MessageCache&i=nope&files=tests%2F&repos= ) [07:34:07] tgr: ^ [07:36:33] huh, thanks [07:36:47] never occured to me that I can just call MessageCache::enable [07:37:00] after that it's easy with the MessagePreLoad hook [18:44:48] CindyCicaleseWMF: If T199044 was moved from "Waiting for Review" to "Ready" because the patch needed rebasing, it prompted me to rebase the patch. ;) [18:44:49] T199044: Special:ActiveUsers queries result in fatal error (due to query/request timeout) - https://phabricator.wikimedia.org/T199044 [18:59:51] anomie: any interest in helping with the https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting tomorrow at 16:00 UTC? [19:00:06] * bd808 is looking for volunteers [19:01:36] anomie: great ;-) Should it move back to "Waiting for Review"? [19:02:13] CindyCicaleseWMF: you might have fun co-hosting a TAIM session too. :) [19:03:16] bd808: serves me right for popping in :-) Unfortunately, I cannot do tomorrow, but maybe another time! [19:03:52] CindyCicaleseWMF: how about 2019-02-06? [19:05:24] bd808: Sure, why not. I'd be happy to help. [19:07:43] * bd808 keeps his eyes open for another victim^Wvolunteer [19:07:54] lol [19:35:26] bd808: Not this week, I have work I need to stop workcrastinating. [19:35:53] anomie: fair enough :) [19:36:07] CindyCicaleseWMF: Yes, moving back to Waiting for Review would be good. I'd have done it but I wasn't sure there wasn't another reason. [19:36:25] anomie: excellent - will do