[00:07:43] anomie: will do [18:39:49] anomie: is https://phabricator.wikimedia.org/T210935 still needed? If so, I assume it's because dropping the column is complicated and we'll do later, but blanking out is an easier short-term win, and also avoids (presumably) potentially undesirable text from remaining in queryable tables. [18:44:27] Krinkle: I wouldn't have bothered to file a task for that in the first place, personally. The only real reason to blank is because it'll probably speed up the ALTER TABLE that drops the columns if the columns are already empty, and we can do rev_comment, rev_user_text, rev_content_mode, and rev_content_format all at once when the time comes for that. [18:45:24] T210935, as far as I can tell, is concerned about the inconsistency from the perspective of the WMCS replicas. But T212972 will take care of that. [18:45:25] T212972: Remove reference to text fields replaced by the comment table from WMCS views - https://phabricator.wikimedia.org/T212972 [18:45:25] T210935: Blank out remaining rev_comment fields on Wikimedia wikis - https://phabricator.wikimedia.org/T210935 [18:45:30] anomie: So the short-term space win doesn't matter, and these are not visible from replicas? [18:45:38] OK [18:45:41] I'll close it then. [18:46:00] anomie: which tasks is for dropping the column(s) [18:47:19] Krinkle: There's no #Schema-Change task yet, because we're not ready to actually do it. When the time comes, though, it'll probably be a subtask of T161671, T184615, and T215466 all at once. [18:47:20] T184615: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields to be dropped from revision - https://phabricator.wikimedia.org/T184615 [18:47:20] T161671: Compacting the revision table - https://phabricator.wikimedia.org/T161671 [18:47:20] T215466: Remove revision_comment_temp and revision_actor_temp - https://phabricator.wikimedia.org/T215466 [18:48:22] '671 is the closest to a task for it at the moment; '615 and '466 cover parts of the combined schema change. [22:28:18] Application Connection Error [22:28:18] Jump to navigationJump to search [22:28:18] Sorry, something went wrong, you'll need to contact the application author for help with this. [22:28:18] Unknown URL, E002 [22:28:19] Return to Main Page. [22:28:23] TimStarling: is anyone planning on reviewing https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/454346/ ? [22:32:34] Reedy: that's a probably bug in the OAuth app [22:33:01] You get it visiting https://meta.wikimedia.org/wiki/Special:OAuth [22:33:03] So filed a bug [22:33:34] well, Special:OAuth is an entry point for OAuth handshakes [22:34:43] oh, you mean the messed up escaping [22:34:50] Yeah [22:35:01] It should maybe fail a bit more gracefully too [22:35:03] "unknown URL" is the error message [22:35:12] (which is admittedly not very helpful)