[00:53:41] tgr: When are we scrapping all the AuthManager stuff? It's some of the oldest deprecation code left in MW. [00:54:09] I think AuthManager is here for a while ;) [00:54:10] I thought we mostly did already? [00:54:28] tgr: See User.php. [00:54:45] I've been carefully avoiding it given that AuthManager stuff is scary. [00:55:21] lol [00:55:23] checkPassword/checkTemporaryPassword/getGroupName/getGroupMember/setPassword/setInternalPassword. [00:56:12] If you're OK with it I can just obliterate them from orbit, but… [00:58:38] I don't know about the group stuff, that's not AuthManager related [00:59:04] they were changed due to WMDE's group membership expiry project I think [00:59:16] https://codesearch.wmflabs.org/search/?q=-%3E(checkPassword%7CcheckTemporaryPassword%7CsetPassword%7CsetInternalPassword)%5C(&i=nope&files=&repos= isn't too bad, but uses in the installer and test suite don't fill me with love. [00:59:23] Ah, right. [00:59:32] set/checkPassword, it's a but scary, yeah [00:59:41] there isn't really an 1:1 replacement [00:59:49] * James_F nods. [01:01:16] ideally we'd do T183420 first [01:01:17] T183420: Authentication data should not be available through the normal DB abstraction layer - https://phabricator.wikimedia.org/T183420 [01:01:24] Whilst I'm grumbling in here, there's the API i18n stuff (getDescription/getParamDescription/getExamples…) in the action API that I've been ignoring too – anomie, is it time for me/someone else to pull that trigger? [01:01:39] move low-level password handling into a separate service, use that in AuthManager, nuke it from User [01:01:47] Ooh, nice plan. [01:02:24] Anyway, consider yourself whined at. I'll shut up now and kill off other things instead. :-) [04:36:23] AaronSchulz: I can do it if the people who have commented already don't want to give +2 [06:34:10] TimStarling: I was thinking the same thing for myself