[15:54:52] greg-g: I see Krinkle merged the patch for T91454. Pinging you to remind you about the discussion starting at T91454#1939833, from an aborted attempt to roll it out with 1.27.0-wmf.11. [15:54:52] T91454: ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91454 [15:56:54] Hey. I'm looking for a devs to review two patches on gerrit: and https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/493464/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/496257/. Anyone has some time and could look at those, please? [15:58:23] Did daniel change his irc name again or is he just not in here? [15:59:28] addshore: I see "duesen has quit (Remote host closed the connection)" about 50 minutes ago, so probably the latter. [15:59:34] anomie: thanks, added to the blocker task with a comment [15:59:44] he is just hiding then, perhaps without knowing it! [15:59:49] anomie: ty [16:02:52] hi duesen [16:02:53] :p# [16:03:22] reverting that patch fixes all of CI, and we have things we need to merge, so once my verification test in CI finished running I'm going to hit +2 [16:52:12] * anomie goes to have lunch, since Phab and Gerrit being down for maintenance means little work can be accomplished. [17:17:06] anomie: presentation time? ;) [21:51:03] duesen: Thoughts on passing $this in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/496257/ - in context of the new RFC? What would we recommend instead?