[00:06:32] anomie, bd808: do you see any chance of merging https://gerrit.wikimedia.org/r/c/mediawiki/core/+/497689 as it is? [00:07:37] I agree Session::getUser() returning a User object flagged as session user is the way forward, but that means cloning the user object that gets passed in in setUser which can result in all kinds of potential breakage [00:08:22] e.g. during registration the user is passed to Session::setUser, and then the secondary provider makes changes on it and those are not reflected in the session user object anymore [00:08:51] so I'd rather do that in a patch that can be rolled back without breaking all of the cloud infrastructure [13:13:45] tgr|away: To unbreak OAuth, why not just do https://gerrit.wikimedia.org/r/c/mediawiki/core/+/497449/1/includes/user/User.php#1878 for now? [16:03:58] anomie: ok, let's do that -> https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/498136 [19:40:49] Reedy: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/496318/ ? :)