[01:02:45] <Krinkle>	 TimStarling: might be unrelated, but if you want wikipeg's CI to be on Node 10, let me know :)
[01:03:40] <TimStarling>	 I just told lego to make it use whatever parsoid uses
[01:03:49] <Krinkle>	 k
[01:04:00] <Krinkle>	 looks like I tried already and it failed for infra reasons https://gerrit.wikimedia.org/r/#/c/wikipeg/+/495594/
[01:04:11] <Krinkle>	 suffers from the same zlib bug
[01:04:40] <Krinkle>	 (our downstream report at https://phabricator.wikimedia.org/T215562 )
[15:08:09] <James_F>	 duesen_: I'm happy to emergency-deploy your fix for T218918, but though the patch looks sane I'd rather someone more expert in the area C+1/+2'ed first.
[15:08:09] <stashbot>	 T218918: Some interface messages (e.g. sitenotice, others) are loading old revisions of their messages - https://phabricator.wikimedia.org/T218918
[15:11:22] <duesen_>	 James_F: ok, thanks. I asked Nikerabbit to give a +1.
[15:11:52] <duesen_>	 in my mind, this isn't a real emergency. no corruption or data loss or security issues.
[15:12:01] <duesen_>	 it's annoying to users
[15:12:39] <James_F>	 I think it's more than annoying; it undermines their confidence in the system behaving as expected.
[15:12:56] <James_F>	 But yes, this isn't a take-the-cluster-down-now! issue, agreed.
[15:14:07] <duesen_>	 what i was trying to say is: I'm happy to see it deployed, but I'm not going to spend a lot of energy trying to make it happen. 
[15:14:52] <James_F>	 Sure.
[15:15:07] <Krenair>	 duesen_, if random versions of messages are being shown couldn't that theoretically include vandalised versions?
[15:15:54] <duesen_>	 yes. not supressed versions, but reverted ones.
[15:16:08] <Krenair>	 was thinking about mentioning that
[15:16:22] <duesen_>	 note that this only affected proper messages, not common.js and friends.
[15:16:25] <duesen_>	 that would be more of an issue
[15:16:45] <Krenair>	 so no raw HTML messages?
[15:16:58] <duesen_>	 raw html messages are affected
[15:17:10] <duesen_>	 anything that'S in the i18n json
[15:17:28] <duesen_>	 so yea, there is potential there. though it's not exploitable, just random
[15:18:39] <Krenair>	 that sounds like shaky territory but okay
[15:19:00] <duesen_>	 I'm all for deploying it asap :)
[15:20:54] <James_F>	 (I'm doing so.)
[15:30:57] <duesen_>	 James_F: thank you!
[15:31:54] <James_F>	 Hey, it's not a fun Friday if there's no reason to deploy something. ;-)
[15:58:21] <James_F>	 duesen_: Deployed.
[19:52:10] <legoktm>	 anomie: thanks, I'll probably submit the missing return stuff as independent patches then